From 9fcf3d7b1b72978748d47dd94da0380af9815d22 Mon Sep 17 00:00:00 2001
From: Kiko Beats <josefrancisco.verdu@gmail.com>
Date: Sun, 30 Jun 2024 14:37:44 +0200
Subject: [PATCH] fix(x): strip query parameter from title

---
 packages/metascraper-x/src/index.js           |   6 +++++-
 packages/metascraper-x/test/index.js          |   2 +-
 .../metascraper-x/test/snapshots/index.js.md  |   2 +-
 .../test/snapshots/index.js.snap              | Bin 1561 -> 1562 bytes
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/metascraper-x/src/index.js b/packages/metascraper-x/src/index.js
index f483c61cc..6db724ac5 100644
--- a/packages/metascraper-x/src/index.js
+++ b/packages/metascraper-x/src/index.js
@@ -30,7 +30,11 @@ module.exports = ({ resolveUrls = false, resolveUrl = url => url } = {}) => {
         return author?.includes(' on X') ? author.split(' on X')[0] : author
       })
     ],
-    title: [toTitle(($, url) => `@${url.split('/')[3]} on X`)],
+    title: [
+      toTitle(
+        ($, url) => `@${new URL(url).pathname.toString().split('/')[1]} on X`
+      )
+    ],
     url: [
       toUrl($ =>
         $('link[rel="canonical"]').attr('href')?.replace('twitter.com', 'x.com')
diff --git a/packages/metascraper-x/test/index.js b/packages/metascraper-x/test/index.js
index 94d31ab8a..1a204e757 100644
--- a/packages/metascraper-x/test/index.js
+++ b/packages/metascraper-x/test/index.js
@@ -21,7 +21,7 @@ const createMetascraper = (...args) =>
   ])
 
 test('from a X profile', async t => {
-  const url = 'https://x.com/Kikobeats'
+  const url = 'https://x.com/kikobeats?mx=2'
   const html = await readFile(resolve(__dirname, 'fixtures/profile.html'))
   const metascraper = createMetascraper()
   const metadata = await metascraper({ url, html })
diff --git a/packages/metascraper-x/test/snapshots/index.js.md b/packages/metascraper-x/test/snapshots/index.js.md
index 3212fef16..f73f189fa 100644
--- a/packages/metascraper-x/test/snapshots/index.js.md
+++ b/packages/metascraper-x/test/snapshots/index.js.md
@@ -15,7 +15,7 @@ Generated by [AVA](https://avajs.dev).
       image: 'https://pbs.twimg.com/profile_images/1717583638991138816/4HvMeeps_400x400.jpg',
       lang: 'en',
       publisher: 'X',
-      title: '@Kikobeats on X',
+      title: '@kikobeats on X',
       url: 'https://x.com/Kikobeats',
       video: null,
     }
diff --git a/packages/metascraper-x/test/snapshots/index.js.snap b/packages/metascraper-x/test/snapshots/index.js.snap
index b8b8a8b37592d56dca150c3056ccb0e0559485f5..a02147776804761d5c538d6d2b147ad9f0cb0d91 100644
GIT binary patch
literal 1562
zcmV+#2IcudRzV<BZeeh9Xm4~Nb~6eC0JC||U+P}{S}4U768fS3vbQ@#sY*J~&fppe
zQd9?kX&;LS00000000BsmraZuM-|6k_hLhctgK}SABx1Ya=?-8nf{oMp2=k<JBxRA
z*Xy;tYp;D^RnuKPT|3oX?W*dTT`NdNLXi+iiJ}OQAfFNkOXL8#gbNZfheRCVl%ua4
z2oe`=sAp#kGa1%n8Ciijz4xkL&s4qN|J9p!!wwgIPrdRU)l74mhEl{xa0gQ<LdGdm
z2}xBXwEF(LK|nOQVScgzUxfT)e98Fo1^{dUz>fjo_W<x~1K>Fm;6)SQyC%SoOn~2+
z0H=)OCynEmI(yXDhVj5$TwDa>1Q<_&@eG_Y%&!;=U>rMX94DEMgdDryc>Z*;$9kgJ
zp+qY@v&MR2XudF&_l1CHI(EM9SWfA@RX*=nTUM=ZTXm~euq^B5RMOJ{Rla1YW+EBI
z%s&E6x-6kovZRamfASk_^r`eIe-T5GB>|NvLX5OdRlQi$1z!|Po0t1b>e_~CPR7HO
ztqeNLn=kbz<LwLH<y%&}wZ<mn-41VE*|#@qt;zV+Slnc8)Qmcl@f+55&)(T~m$S+E
zX7iRyx0a*0J+<FsEGFFtr*v_gly+1>4_MqS_#!Tj>c2aDRu%24T`hZV#r0}6+jc$A
zt`tiv{fm^QYPV!r`z6aN?4{l5dT^3-$Bs#pspY5Atizd#=z~fdJJUaQ$mQ63rqLUh
z9z}xF4=-erkL|CG_q9LV&jVzp-`{5e6+>^~#7G7E-<p;IN~#3!=PYbrSywYu@w1~;
zAq;>|41j-()X_EpUj83c#SiCFMa+CDI7@m3CQwtwNt7izcd~@^i6%0)d-R|m-74&<
zf{<MlO2lKkBgH^b$*EG~P)s#Zz9cD?qtO2o(`!$H>2H6A=>gLb>H(!%9ooaR8EpS*
z7Td1^z#jnM6$9XJ2Ed{T;EuZfYmd$LbE~A!aQ)r~DZP#Ne}4C`AHIrb_DG*`kv<CE
zZn^H*^Wyy`EQvTJQVZ0X7LpN8)j5o)lq6;}(L~_^CPFix5rqN8cC&!r$&!EsLSo}0
z=_V{>{%*64pT7OZFY!Wl?|p*prm9c2=GA68h|61XDDcy_fBIIwxeYo{oN7(w)U*2H
z^7<uv)4SgLZy;ax>`Jxfc@?KpbuHWTyy8nM7jCAP{K^wV{zPL`%7+2}>?H7`tl}KJ
z^AYYtzCX+K!s0BZ-vEG*^PX)0oHYSfO@P=0c*g|z`(rbGx+N0A16(cOmdxT5&qzx6
zVQ?6DB(Q6Bw=yr-e}emWesR^0SQui56QyZ@p^!Ps7z#gAc{>*gE)mW`ArnS05-}Zi
z;QM#p#6~FgNfLyT(Iil~!W6cc(vtZanL?JJrc$yFr>G*5(gLo~e1V`Zq|8!{so*$>
z1d4<oU?3@pRen|Ih+;cVDe<G2CK^`+*)L!_!T110$`U3LjE1kumkH04sU%642B(jd
z!}?ru@Tw)JTCr<Yw_GjPDwV2J>}_X}wygLGs^P1RDGnZ{3U5*sQ`tqOiOy8fb{wZ>
zRh_csdahF{yN)%7ZU+CZo5O2?V3&n6u7$m$MjqDyc-=VsL-1z<z%T(eJ|81b$*Pyi
zb4th9Sl&;mWI2AhNQMWp#3_*-rm?x%#<SQ=Q%-T~8oDjqB$9AW_9uJzWfj{Mw^xc+
zkA${48`@zhc89gv)ln9Aimg^Ba<4D#+-Np$hPP`uqjgSXmwtXm75hJoDq}i5&$8W`
z?UbrD+j45viaXB`^UWD_COACA8GwFo7N9=>fZqbZH3Q(T0q~Il@D~H%SrdRfHlQc3
z#zgAvCZ5?QL-Ucq^y<#MJ>59CkvH9#B_tLKDaU~2?KZ)sjO$F2d_19XDycdQH&UX7
z6uvlzjgX6!-sTxo=WvZ^M$Ta~>E64`nNN@=*ziR_W08N|E>-yazg)+%t4A_ip3QJf
z14fFiO%hyMOLzQcd;R>z^(V&diN>fJ52Lm?N$n_W%xujq*;d7?TAo`fl}lx(b`-P!
M1VBMEeOwU$08-oj)c^nh

literal 1561
zcmV+!2Il!eRzV<BZeeh9Xm4~Nb~6eC02_KIhroV@O=fGS0yBwD0jLK+ts-e5an&10
znXqY~z8{MS00000000B+mraZu#TCb2_XZ~<vRDg3K7^EKali<Bra$JRXSmF;vv_B{
zUa#@4z4jrin(pf9+NthpS5?pKT8TuY2q_8@QG@^q2mvVvOW}}kA(u#za{%QCCyu^y
z03<HlqMn`EWQNIlEJqfRGN<=m_3N3c_xrzk^LE(b!tbdU-l3XlPSa3|7zu7;Dn-aR
zWhx=5iiB3bcsmG)CRfc*7U0{Ee~j-K-(3fQO#pZi0R9F5e=-0bGXb790e)%%{MrQg
zs|oP1aqNU~>_TUk`r0rK&Bet<Fph)qAQ%t9!-n~Yu>i&cCyZkx(~*#4_eYPPEcRGW
z6g!k?g{RK3o*0@>PUU?oAexSyA3By(I%Ad3IM$|BtJ_xHsue8Dx;B;cy?`oTvQ#sX
zjAG_LfF@m*P%2r{#oMp^85?~neafH4P-IC!C5jLuty5Jm7IncF#nQ&b{*t=9u9}na
zFl8%)&ho}H{mFRytatIc)oz_*lkskcx1QUxH)^fP_@!7}V{X)pI+O9M)>hBn-g1|-
z$@oU|x=S~gqqse_-v?Msx`(H9ew>tcR6!3|+%5PbE{^KIGkjJR?W$cZdv3+`YBk$-
zJ<qNbODp~Jl%{H@WLbM9%PQ=q-RXL8l61$8Nt3DN2h*&>nTqIPrH$?BA3Nl7>^;;t
zEIo<@rypL(Bp=&981HLuxSzwk>G$_pK*i8oI6hLr-cP1wfRZY~`#B3+&#kE$s(9@v
zRR{y%69eF@kviHYz|Z~%Rq?C2R1q^@3eJ*VfeF-9aS~;T&YdhFeWHoX?H=9lN7oCx
zsvu++g%a`D?np6ERC21+I22P&lrKq2<tX%jrtgyJC%(q?fawVJfKsgv>|xprw*NSb
z?Uw-H?*Q<E0q}(ZuxJ9fqpts(duIEwRnlj;cI&;A-oV?h-~8<Tm+;gs=`$|UyTRKn
z*ByIayx)W+5vN3IfjZMdGQz1kjS-cS#Ed4IDBQ<HXy!AbFre6O7Vz0D2}mF$HqMi7
z!b0ZnG~4+3TQC0s&t|vYCD?AN`ebWfZKi{`ycvfAKY#1h-{qTIrvt^Q)>KYCtIsd5
zU9dO2E4}{)@@3DiRBN7BaVk~UvOUi$KC^Q6T6)2++(+b(H%6tr6Y!5t0zb+s&cQn$
z;XdU1>r5{!&SLsy0QfNP*#^K<Ccvr*5SswMHvzu9XQofKL_&Cgs|DPYS)Af2NeMp)
z4g+@ucCGGK<^}sBxc&Sam;8u@A$B-Xng$pOnWK!M@H3USbCKW@;Vcv~VFV))(_sg`
z{rsEQ2*n;rf>1J=1PWJ}!WL6nGG8N8$P(04O4i{NRYX!+z!jP=5cGwVS*kG=90!p=
zk??&CBqg!RuL>PeY{w}jeiYM0<BA}A1#Bl6@1sar!bF16@KyOT;dwHZB<a%N<dJe%
zn@bK}wd7PQcCG4`tL0jyQgw>Gtt`@(72iiSe7`Zp!JSm$O{!ulyQnnLnJU_j<J7FG
zQ?^{sbxLK|vF6at;NNv~a4it*vT(+=uzS?V;~D_JH4gp|d~5(1CcyePW8^7W^-_6G
z=@{$FdnuJH$1fMj@IaP0C9=abHaFV%6gJb8Q{23aZVNYvB%G7I$sT@D#dgK*mEzSS
zp>58Fc36s?VXby_l*OH5tJR6zD@)r~o6T$CjatrVofFxm-<(m!{tu(dm`=~LY`11R
zrE1N#oLaTw&NIaPcm|yb4i9k#pg*4l=q~}_F92}a0Jv!Yd|&{4Y5+WH0+4$K^u(o@
zNWIm>Q(I(c-W8Z$-I=$i8~a!DrW><_#6ltE7_hwECb*Pwok^09Cp1naRR`flO0<x|
z7pJiia*@&-JY(uKo+Fx()7VV9w{CLg6Ql_?d=b!C<X^W#6+Zqi*RkyCkqnn-GaS=^
zkz#9u1Q*Vw+kUgXc4qy`edG3cV^obhQCpm(c9b<{w&s>>tKwBH&n=b8rLt2yirIex
LK9M@iToC{OaWe!S