From ec49eff93c1114361dacf7d7a45ba3571d954db6 Mon Sep 17 00:00:00 2001 From: Kiko Beats Date: Mon, 21 Oct 2024 09:55:53 +0200 Subject: [PATCH 1/3] test: skip vimeo --- .../metascraper-media-provider/test/fixtures/generate.js | 2 +- packages/metascraper-media-provider/test/video/index.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/metascraper-media-provider/test/fixtures/generate.js b/packages/metascraper-media-provider/test/fixtures/generate.js index bd5b965e2..000d78bcd 100644 --- a/packages/metascraper-media-provider/test/fixtures/generate.js +++ b/packages/metascraper-media-provider/test/fixtures/generate.js @@ -4,7 +4,7 @@ const youtubedl = require('youtube-dl-exec') const path = require('path') const fs = require('fs/promises') -const { getFlags } = require('../../src/get-media/provider/generic') +const { getFlags } = require('../../src/get-media') let [, , url, filename] = process.argv diff --git a/packages/metascraper-media-provider/test/video/index.js b/packages/metascraper-media-provider/test/video/index.js index 014e1684f..84e928232 100644 --- a/packages/metascraper-media-provider/test/video/index.js +++ b/packages/metascraper-media-provider/test/video/index.js @@ -9,13 +9,14 @@ const { metascraper } = require('../helpers') const isCI = !!process.env.CI ;[ + // TODO: vimeo is not exposing an HTTP endpoint URL for the video // TODO: uncomment when the issue is resolved // https://github.com/ytdl-org/youtube-dl/issues/29205 // 'https://vimeo.com/channels/staffpicks/287117046', // 'https://vimeo.com/showcase/3717822', - 'https://vimeo.com/443437002' + // 'https://vimeo.com/443437002' ].forEach(url => { - ;(isCI ? test.skip : test)(url, async t => { + test.skip(url, async t => { const metadata = await metascraper({ url }) debug(metadata.video) t.is(extension(metadata.video), 'mp4') From 4f3c66062d17b932c9cb9228f0fbca92f1ef936a Mon Sep 17 00:00:00 2001 From: Kiko Beats Date: Mon, 21 Oct 2024 10:37:12 +0200 Subject: [PATCH 2/3] test: update snapshot --- .../test/snapshots/index.js.md | 2 +- .../test/snapshots/index.js.snap | Bin 732 -> 730 bytes 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/metascraper-manifest/test/snapshots/index.js.md b/packages/metascraper-manifest/test/snapshots/index.js.md index 34edab3b3..3d6746c66 100644 --- a/packages/metascraper-manifest/test/snapshots/index.js.md +++ b/packages/metascraper-manifest/test/snapshots/index.js.md @@ -77,7 +77,7 @@ Generated by [AVA](https://avajs.dev). { description: null, lang: null, - logo: 'https://www.gstatic.com/youtube/img/branding/favicon/favicon_192x192_v2.png', + logo: 'https://www.gstatic.com/youtube/img/branding/favicon/favicon_192x192.png', publisher: 'YouTube', } diff --git a/packages/metascraper-manifest/test/snapshots/index.js.snap b/packages/metascraper-manifest/test/snapshots/index.js.snap index 4f1e01cbca3b09bb4f806055fa4ed1f2caf7dc7e..e685622155fd0257447ac74975642495d40458cb 100644 GIT binary patch literal 730 zcmV<00ww)HRzVx95;csv|?a`p%REUwG%qq zkL_#Dch)`UBpn#oSlL+1r(oqf@Cg_hnL$EM?6&kJ%@%xu8m8jPPmMDCbW!^9Dn^{kIV58w3bqt;u*<6ECd1Q0M`>HLcPgbE~x3V$W0Oa@zI%z7??&o)S8e zI`NY3j(HG-^3Zb@b%>n-+7MMo`@IKS zy@wlqY>jq)EC%DmOrAIiPMBJgp|{!XjW)Y8M5ozeOK-+gRFZwdBtz{krQH8LP4e43 zC3kDdGw(k!q}q!9{=Bw(qwU#*mS0Zhtci|H;fesSNZZOZqwn)HdRiL|hr>=nPBU^RgG074xhh8MgV*SQT*`pmx;elpE`aQ)nzw zn+qLrmm*ifm4D+znLw!Vl$@Ng5{U~c?>ORxj*W`A$AwaSC|$}G5{+AOXZ97mh|Bi> M0C1v9jz0+i0F7K+>i_@% literal 732 zcmV<20weuFRzV_Ld=cE^e=J?b>2{ zw%0M=z8{MS00000000Bs)w^=jKokbxvvHhonLs?@0k(k7vSO19$xzTykQo?mlT?|N zbR=!E+STk?*-k-0M@vT=o`RNl;1y^nsbPkZEhQlr$DIe%=(5s|&bPmgj^jX?@Q^-y zMkk%Zp%)n>u8m8jPPmMDCbW!^9Dnn2hs)6rw}16u+%59}_iu(^Az0j$|#w#sl#a^V&<+SblhgQT&cuMF< z>cmUBTV^c?<$>oc>JU49v>~dF$aBA3Z(r!h8X0-ziPzog4ZB;tPOg(_Q}p0`ifXjq)Ec&CwjGs6OPMBJgp|{@c4cEI*OXrT9R)lq)0}b>+_Vi+B;2 O?fwB+yG;T@2><|)7*Rn0 From 48d19897065f3c5cf1fbde4bda5f010e94a480e4 Mon Sep 17 00:00:00 2001 From: Kiko Beats Date: Mon, 21 Oct 2024 12:01:17 +0200 Subject: [PATCH 3/3] test: skip instagram --- packages/metascraper-media-provider/test/video/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/metascraper-media-provider/test/video/index.js b/packages/metascraper-media-provider/test/video/index.js index 84e928232..dfa20f796 100644 --- a/packages/metascraper-media-provider/test/video/index.js +++ b/packages/metascraper-media-provider/test/video/index.js @@ -30,7 +30,7 @@ const isCI = !!process.env.CI }) }) ;['https://www.instagram.com/p/BmYooZbhCfJ'].forEach(url => { - ;(isCI ? test.skip : test)(url, async t => { + test.skip(url, async t => { const metadata = await metascraper({ url }) debug(metadata.video) t.true(isUrl(metadata.video))