-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Bundle Registration Process #424
Comments
Remember firewall rules needs to be added for other ACR instances. Ref #421 |
@Lybecker not sure they do as ACI pulls over the public internet. See https://docs.microsoft.com/en-us/azure/container-instances/container-instances-using-azure-container-registry#limitations |
@marrobi Since this is listed as an API story - do you mean a cosmos repository? or are we talking something else? |
Container image repository. |
@marrobi, recent changes in the registration script (#1278) made porter use a bundle image stored on a remote container registry. However, to fully register a new TRE template the process also needs the template_schema.json available in the source code on the bundle/template. |
We discussed a while back possiblity of having a custom action that prints the schema file. I tried this and it does work but feels messy. Unless we can extract a file another way open to suggestions. |
If we want to separate bundle creation from registration, then the only additional way would be to somehow get a url where the file can be accessed. P. S. Currently the resource processor can only access one container registry. |
Just adding as a note, can retrieve single file from a porter bundle using:
|
Description
As a TRE System Integrator
I want to specify the full repository where a bundle is stored
So that I can store templates in different locations
As a TRE System Integrator
I want the bundle to be read and imported without the need to manually generate a payload and call the API.
So that I can quickly register new bundles
Acceptance criteria
repository
repository
Notes:
Docker calls the combination of
[registry-url]/[namespace]/[image]
a repository. For examplehttps://myregistry.azurecr.io/workspaces/azureml
The text was updated successfully, but these errors were encountered: