Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Bundle Registration Process #424

Open
4 tasks
marrobi opened this issue Jul 7, 2021 · 8 comments
Open
4 tasks

Enhance Bundle Registration Process #424

marrobi opened this issue Jul 7, 2021 · 8 comments
Labels
api Composition Service API enhancement New feature or request

Comments

@marrobi
Copy link
Member

marrobi commented Jul 7, 2021

Description

As a TRE System Integrator
I want to specify the full repository where a bundle is stored
So that I can store templates in different locations

As a TRE System Integrator
I want the bundle to be read and imported without the need to manually generate a payload and call the API.
So that I can quickly register new bundles

Acceptance criteria

  • Post/register template operations accepts and stores a repository
  • Post/register template operation extracts template details using resource processor and stores template details
  • Get Workspace Template returns the repository
  • Post Workspace with successfully deploys the workspace

Notes:

Docker calls the combination of [registry-url]/[namespace]/[image] a repository. For example https://myregistry.azurecr.io/workspaces/azureml

@marrobi marrobi added enhancement New feature or request api Composition Service API story Stories are the smallest unit of work to be done for a project. labels Jul 7, 2021
@marrobi marrobi modified the milestones: Next, Backlog Jul 7, 2021
@Lybecker
Copy link
Member

Lybecker commented Jul 7, 2021

Remember firewall rules needs to be added for other ACR instances. Ref #421

@marrobi
Copy link
Member Author

marrobi commented Jul 7, 2021

@TessFerrandez
Copy link
Member

TessFerrandez commented Aug 26, 2021

@marrobi Since this is listed as an API story - do you mean a cosmos repository? or are we talking something else?

@marrobi
Copy link
Member Author

marrobi commented Aug 26, 2021

Container image repository.

@marrobi marrobi modified the milestones: Backlog, Release 0.4 Nov 25, 2021
@marrobi marrobi added feature and removed story Stories are the smallest unit of work to be done for a project. labels Nov 25, 2021
@marrobi marrobi modified the milestones: Release 0.4, Release 0.5 Nov 25, 2021
@marrobi marrobi changed the title [Story] Store Workspace Template Repository [Feature] Enhance Bundle Registration Process Nov 25, 2021
@marrobi marrobi changed the title [Feature] Enhance Bundle Registration Process Enhance Bundle Registration Process Jan 11, 2022
@tamirkamara
Copy link
Collaborator

tamirkamara commented Feb 27, 2022

@marrobi, recent changes in the registration script (#1278) made porter use a bundle image stored on a remote container registry. However, to fully register a new TRE template the process also needs the template_schema.json available in the source code on the bundle/template.
Do you have any thoughts around that?

@marrobi
Copy link
Member Author

marrobi commented Feb 27, 2022

We discussed a while back possiblity of having a custom action that prints the schema file. I tried this and it does work but feels messy.

Unless we can extract a file another way open to suggestions.

@tamirkamara
Copy link
Collaborator

tamirkamara commented Feb 27, 2022

If we want to separate bundle creation from registration, then the only additional way would be to somehow get a url where the file can be accessed.
But that brings me to another question, how would the flow look like? Would the TRE system integrator still need to register the templates one by one? Is the assumption that they were the ones who also published the bundles?

P. S. Currently the resource processor can only access one container registry.

@marrobi marrobi removed this from the Release 0.5 milestone Mar 30, 2022
@marrobi
Copy link
Member Author

marrobi commented Mar 31, 2022

Just adding as a note, can retrieve single file from a porter bundle using:

image="mrtreint.azurecr.io/tre-service-guacamole-linuxvm-installer:v0.1.7"
container_id=$(docker create "$image")
docker cp "$container_id:/cnab/app/azure.json" "tmp_json.json"
docker rm "$container_id"

@marrobi marrobi added this to the Release 0.4 milestone Mar 31, 2022
@marrobi marrobi modified the milestones: Release 0.4, Backlog Jun 29, 2022
@marrobi marrobi removed this from the Backlog milestone Jun 27, 2023
@marrobi marrobi removed the feature label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Composition Service API enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

4 participants