Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev container build failure on mount config and CI fixes #4290

Merged
merged 12 commits into from
Feb 5, 2025

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jan 29, 2025

Fixes #4271

Add an initializeCommand to create necessary directories before the build.

  • Add initializeCommand in devcontainer/devcontainer.json to create $HOME/.azure and $HOME/.config directories if they do not exist.
  • Ensure the command runs before the container is created to prevent build failures due to missing directories.

Also fixes a number of CI issues.

Fixes #4271

Add an `initializeCommand` to create necessary directories before the build.

* Add `initializeCommand` in `devcontainer/devcontainer.json` to create `$HOME/.azure` and `$HOME/.config` directories if they do not exist.
* Ensure the command runs before the container is created to prevent build failures due to missing directories.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4271?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

github-actions bot commented Jan 29, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4687809.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13138762021 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13140204598 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13140644722 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141112878 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141540844 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13141937538 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13142415300 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13142870248 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi marrobi changed the title Fix dev container build failure on mount config Fix dev container build failure on mount config and CI fixes Feb 4, 2025
@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13143573702 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13143614529 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 4, 2025

/test

Extended passed here, but I messed up the devcontainer location (or copilot did...)

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13145543168 (with refid 1f63de94)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) February 4, 2025 22:25
@marrobi marrobi merged commit d61965d into main Feb 5, 2025
12 checks passed
@marrobi marrobi deleted the marrobi/marrobi/fix-dev-container-mount-paths branch February 5, 2025 05:14
@jonnyry
Copy link
Collaborator

jonnyry commented Feb 5, 2025

@marrobi

getting the following after pulling this change:

image

It appears to be trying to run initializeCommand on the Windows command line, rather than Bash.

@marrobi
Copy link
Member Author

marrobi commented Feb 5, 2025

Hmm. Worked on my machine!

Wonder if it depends how you open vscode. Let me to a search. We can revert it if need be.

@marrobi
Copy link
Member Author

marrobi commented Feb 5, 2025

Looks like need to create a script - microsoft/vscode-remote-release#4568 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Container build fails on mount config if folders don't exist on local filesystem.
3 participants