-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev container build failure on mount config and CI fixes #4290
Conversation
Fixes #4271 Add an `initializeCommand` to create necessary directories before the build. * Add `initializeCommand` in `devcontainer/devcontainer.json` to create `$HOME/.azure` and `$HOME/.config` directories if they do not exist. * Ensure the command runs before the container is created to prevent build failures due to missing directories. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4271?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4687809. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13138762021 (with refid (in response to this comment from @marrobi) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13140204598 (with refid (in response to this comment from @marrobi) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13140644722 (with refid (in response to this comment from @marrobi) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141112878 (with refid (in response to this comment from @marrobi) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141540844 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13141937538 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13142415300 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13142870248 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13143573702 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13143614529 (with refid (in response to this comment from @marrobi) |
/test Extended passed here, but I messed up the devcontainer location (or copilot did...) |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13145543168 (with refid (in response to this comment from @marrobi) |
getting the following after pulling this change: It appears to be trying to run initializeCommand on the Windows command line, rather than Bash. |
Hmm. Worked on my machine! Wonder if it depends how you open vscode. Let me to a search. We can revert it if need be. |
Looks like need to create a script - microsoft/vscode-remote-release#4568 (comment) |
Fixes #4271
Add an
initializeCommand
to create necessary directories before the build.initializeCommand
indevcontainer/devcontainer.json
to create$HOME/.azure
and$HOME/.config
directories if they do not exist.Also fixes a number of CI issues.