Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in UI Airlock File uploads and downloads. #4309

Open
fortunkam opened this issue Feb 4, 2025 · 5 comments
Open

Support in UI Airlock File uploads and downloads. #4309

fortunkam opened this issue Feb 4, 2025 · 5 comments
Assignees
Labels

Comments

@fortunkam
Copy link

Is your feature request related to a problem? Please describe.
The Airlock process currently uses Storage SAS tokens for uploading and download files. This causes issues in highly regulated environments where SAS token (and shared key) access needs to be disabled on storage accounts.

Describe the solution you'd like
Would be nice to be able to Upload and Download files to the UI via the Airlock request pages. The solution would need to happen in the browser to preserve the networking constraints (e.g. You should only be able to upload to the import external storage account if you have network visibility to it)

Describe alternatives you've considered
Having up files uploaded via the API won't work because it breaks some of the networking constraints and there is a 2GB limit for file upload requests to an API in most browsers.

@TonyWildish-BH
Copy link
Contributor

Is there any reason to re-work the UI to support this when there's already the Azure Storage Explorer which does what's needed?

It seems to me the real issue here is not to add support to the UI, but to eliminate the use of SAS URLs, which is what #4308 is about.

@West-P
Copy link

West-P commented Feb 12, 2025

Is there any reason to re-work the UI to support this when there's already the Azure Storage Explorer which does what's needed?

It seems to me the real issue here is not to add support to the UI, but to eliminate the use of SAS URLs, which is what #4308 is about.

I can see a benefit in having the ability to upload/download via the UI. Researchers may not be Azure aware and containing the airlock process to the UI would help both for introducing a researcher to the airlock process and for efficiency in the process as a whole.

@TonyWildish-BH
Copy link
Contributor

I can see how that may help some users, but it can't be the only way to do it, that would be too restrictive. So if this is additional functionality, that's fine with me, but if it replaces what's there, it doesn't work for me.

So we have two issues here then:

  • Simplify the airlock process for people who aren't able to use the Storage Explorer or CLI options. Updating the UI is certainly one way to do it, ergo this ticket.
  • Eliminate the use of SAS URLs for those who do use Storage Explorer or CLI. That will allow disabling pasting into the workspace VMs (for those who want that, like us), and, coupled with the other suggestions for redesigning the airlock, will also simplify the process - Redesign Airlock Export Process to Eliminate SAS URLs #4308 and others.

@marrobi
Copy link
Member

marrobi commented Feb 12, 2025

@TonyWildish-BH this is additional functionality. It would be helpful if do not confuse the issue by commenting on related but different things.

If you just want to mull ideas over, rather than having a specific feature request it might be best to use https://github.com/microsoft/AzureTRE/discussions .

@TonyWildish-BH
Copy link
Contributor

I do have a specific feature request, it's in #4308. I only commented here because the discussion in #4308 suggested that this, and other tickets, make #4308 redundant. They do not.

Thank you for clarifying that this ticket is about additional functionality, not replacement. That was not clear from the discussion so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Status: In Progress
Development

No branches or pull requests

4 participants