Question about ticks calculation

[jmelas]

MIDI/src/api/Client/WinMM/MidiSrvPort.cpp

Line 357 in 7ca0062

DWORD ticks = (DWORD) (((position - m_StartTime) / m_qpcFrequency) * 1000.0);

this does an integer division (with truncation) and converts to double after that:
DWORD ticks = (DWORD) (((position - m_StartTime) / m_qpcFrequency) * 1000.0);

was this the intent (no truncation):
DWORD ticks = (DWORD) ((position - m_StartTime) * 1000.0 / m_qpcFrequency);

if not then why not skip converting to double (might be faster)
DWORD ticks = (DWORD) (((position - m_StartTime) / m_qpcFrequency) * 1000);

[Psychlist1972]

@garydan42 as I'm not sure if this is net new code, or was lifted from the original WinMM port implementation.

[garydan42]

Good catch, should do the calculation without truncation.

[jmelas]

Can I submit a PR for this? If yes do you want a new function, a new macro, or just inplace fixes? (the truncation occurs in several lines)

[Psychlist1972]

Can I submit a PR for this? If yes do you want a new function, a new macro, or just inplace fixes? (the truncation occurs in several lines)

Happy to have a PR if you want to submit one. Create a macro and submit a PR. :)

Thanks!

[jmelas]

Thanks PR ready!
#559