diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c0c9fcc04..2d83b63653 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ * AADAppplication * Fixed an issue where specifying an empty ReplyURLs array would not remove the existing entries. +* AADAuthenticationMethodPolicy + * DEPRECATED - PolicyMigrationState property is now deprecated since it +* AADAuthenticationMethodPolicyFido2 + * Fixed issue where the Set-TargetResource was throwing an internal server + error. + cannot be set. * EXOCalendarProcessing * Changed the Get-TargetResource logic to return UPN instead of id. * EXODistributionGroup diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicy/MSFT_AADAuthenticationMethodPolicy.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicy/MSFT_AADAuthenticationMethodPolicy.psm1 index b5726ac698..91f7e261dc 100644 --- a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicy/MSFT_AADAuthenticationMethodPolicy.psm1 +++ b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicy/MSFT_AADAuthenticationMethodPolicy.psm1 @@ -246,19 +246,11 @@ function Get-TargetResource } #endregion - #region resource generator code - $enumPolicyMigrationState = $null - if ($null -ne $getValue.PolicyMigrationState) - { - $enumPolicyMigrationState = $getValue.PolicyMigrationState.ToString() - } - #endregion - $results = @{ #region resource generator code Description = $getValue.Description DisplayName = $getValue.DisplayName - PolicyMigrationState = $enumPolicyMigrationState + #PolicyMigrationState = $enumPolicyMigrationState #DEPRECATED - Cannot be set PolicyVersion = $getValue.PolicyVersion ReconfirmationInDays = $getValue.ReconfirmationInDays RegistrationEnforcement = $complexRegistrationEnforcement @@ -405,6 +397,13 @@ function Set-TargetResource $UpdateParameters.$key = Convert-M365DSCDRGComplexTypeToHashtable -ComplexObject $UpdateParameters.$key } } + + if (-not [System.String]::IsNullOrEmpty($PolicyMigrationState)) + { + Write-Verbose -Message "DEPRECATED - Property PolicyMigrationState cannot be set." + $UpdateParameters.Remove('PolicyMigrationState') | Out-Null + } + #region resource generator code $UpdateParameters.Add('@odata.type', '#microsoft.graph.AuthenticationMethodsPolicy') Write-Verbose -Message "Updating AuthenticationMethodPolicy with: `r`n$(Convert-M365DscHashtableToString -Hashtable $UpdateParameters)" @@ -534,6 +533,7 @@ function Test-TargetResource } $ValuesToCheck.remove('Id') | Out-Null + $ValuesToCheck.remove('PolicyMigrationState') | Out-Null Write-Verbose -Message "Current Values: $(Convert-M365DscHashtableToString -Hashtable $CurrentValues)" Write-Verbose -Message "Target Values: $(Convert-M365DscHashtableToString -Hashtable $ValuesToCheck)" diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyAuthenticator/MSFT_AADAuthenticationMethodPolicyAuthenticator.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyAuthenticator/MSFT_AADAuthenticationMethodPolicyAuthenticator.psm1 index 2aa573fcff..16506f6633 100644 --- a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyAuthenticator/MSFT_AADAuthenticationMethodPolicyAuthenticator.psm1 +++ b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyAuthenticator/MSFT_AADAuthenticationMethodPolicyAuthenticator.psm1 @@ -690,6 +690,7 @@ function Set-TargetResource } } #region resource generator code + Write-Verbose -Message "Parameters:`r`n$(ConvertTo-Json $UpdateParameters -Depth 10)" $UpdateParameters.Add('@odata.type', '#microsoft.graph.microsoftAuthenticatorAuthenticationMethodConfiguration') Update-MgBetaPolicyAuthenticationMethodPolicyAuthenticationMethodConfiguration ` -AuthenticationMethodConfigurationId $currentInstance.Id ` diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyFido2/MSFT_AADAuthenticationMethodPolicyFido2.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyFido2/MSFT_AADAuthenticationMethodPolicyFido2.psm1 index 16563ea3c1..66e656bb0f 100644 --- a/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyFido2/MSFT_AADAuthenticationMethodPolicyFido2.psm1 +++ b/Modules/Microsoft365DSC/DSCResources/MSFT_AADAuthenticationMethodPolicyFido2/MSFT_AADAuthenticationMethodPolicyFido2.psm1 @@ -341,8 +341,6 @@ function Set-TargetResource $UpdateParameters = ([Hashtable]$BoundParameters).clone() $UpdateParameters = Rename-M365DSCCimInstanceParameter -Properties $UpdateParameters - $UpdateParameters.Remove('Id') | Out-Null - $keys = (([Hashtable]$UpdateParameters).clone()).Keys foreach ($key in $keys) { @@ -378,7 +376,7 @@ function Set-TargetResource } } #region resource generator code - $UpdateParameters.Add('@odata.type', '#microsoft.graph.fido2AuthenticationMethodConfiguration') + Write-Verbose -Message "Parameters:`r`n$(ConvertTo-Json $UpdateParameters -Depth 10)" Update-MgBetaPolicyAuthenticationMethodPolicyAuthenticationMethodConfiguration ` -AuthenticationMethodConfigurationId $currentInstance.Id ` -BodyParameter $UpdateParameters