Report LCM details only if running as administrator #5635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR improves the telemetry engine by only reporting the LCM details if the current session is running as administrators. Previously, it was always attempted to get the LCM details using
Get-DscLocalConfigurationManager
, but this wouldn't work for standard users. In their case, it would always throw aAccess denied
exception which is caught and silenced - Nobody knew it was failing. Now, it will check if the current session is elevated and only report those details if they are available.Inspired by #5615 to check the telemetry engine for optimizations.
Previously: Export took 187 seconds.
Afterwards: Export took 19 seconds.
Speedup: Factor 10
This Pull Request (PR) fixes the following issues
None.
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).