Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing delimiter when called without parameter #5636

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fix missing delimiter when called without parameter #5636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eddf36a
Fix missing delimiter when called without parameter
Jan 16, 2025
45fc59a
Merge branch 'Dev' into fix/csv-report
Jan 16, 2025
fd31e88
Merge branch 'Dev' into fix/csv-report
ykuijs Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
* Added support for the AllowGetOneLakeUDK, AllowMountDfCreation, AllowOneLakeUDK,
ArtifactOrgAppPreview properties.
* Fix values that have a zero length whitespace character.
* M365DSCReport
* Fix missing delimiter when called without the parameter.
FIXES [#5634](https://github.com/microsoft/Microsoft365DSC/issues/5634)
* M365DSCTelemetryEngine
* Report LCM details only if running as administrator.

Expand Down
1 change: 1 addition & 0 deletions Modules/Microsoft365DSC/Modules/M365DSCReport.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,7 @@ function New-M365DSCReportFromConfiguration
$delimiterParam = [System.Management.Automation.RuntimeDefinedParameter]::New("Delimiter", [System.String], $attributeCollection)
$delimiterParam.Value = ';' # default value, comma makes a mess when importing a CSV-file in Excel
$paramDictionary.Add("Delimiter", $delimiterParam)
$PSBoundParameters.Add("Delimiter", $delimiterParam.Value)
}
return $paramDictionary
}
Expand Down