Add AuditEnabled to EXOSharedMailbox #5748
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
-PropertySets is not a valid property for the Get-Mailbox cmdlet. What are we trying to accomplish with this PR? |
|
I mistakenly added -PropertySets All to Get-Mailbox as I confused it with Get-EXOMailbox. I am not very experienced with Powershell yet, so I am sorry for the inconvenience. Thanks for your understanding! |
|
@NikCharlebois LGTM. |
NikCharlebois
requested changes
Feb 26, 2025
| @@ -93,6 +97,7 @@ function Get-TargetResource | |||
| -RecipientTypeDetails 'SharedMailbox' ` | |||
| -ResultSize Unlimited ` | |||
| -ErrorAction Stop | |||
| -PropertySets All | |||
| @@ -101,6 +106,7 @@ function Get-TargetResource | |||
| -RecipientTypeDetails 'SharedMailbox' ` | |||
| -ResultSize Unlimited ` | |||
| -ErrorAction Stop | |||
| -PropertySets All | |||
There was a problem hiding this comment.
PropertySets is not a valid property of the Get-Mailbox cmdlet
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Looks like an old version of the change log. Please refresh your branch with the latest changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds AuditEnabled to EXOSharedMailbox
This Pull Request (PR) fixes the following issues
None
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).