Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5742: Ensure TermsOfUse is an array in AADConditionalAccessPolicy #5772

Merged
merged 11 commits into from
Feb 26, 2025

Conversation

Pranaykarvi
Copy link
Contributor

Fix for Issue #5742

Summary

  • Fixed an issue where TermsOfUse was not passed as an array, causing failures in GCC-High environments.
  • Updated MSFT_AADConditionalAccessPolicy.psm1 to wrap TermsOfUse ID in @().

Changes Made

  • Updated Modules/Microsoft365DSC/DSCResources/MSFT_AADConditionalAccessPolicy/MSFT_AADConditionalAccessPolicy.psm1
  • Wrapped $TermsOfUseObj.Id in an array to ensure compliance.

Issue Reference

Fixes #5742

Copy link
Collaborator

@FabienTschanz FabienTschanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an entry to the changelog as well?

@Pranaykarvi
Copy link
Contributor Author

@FabienTschanz I have also made an entry to the changelog

Co-authored-by: Fabien Tschanz <[email protected]>
@FabienTschanz
Copy link
Collaborator

@NikCharlebois LGTM.

@Pranaykarvi
Copy link
Contributor Author

@FabienTschanz the branch shows merge conflicts please can you check?

@FabienTschanz
Copy link
Collaborator

@Pranaykarvi I don't have the permission to do so. @NikCharlebois Can you assist?

@NikCharlebois NikCharlebois merged commit a5e1787 into microsoft:Dev Feb 26, 2025
3 checks passed
@Pranaykarvi Pranaykarvi deleted the fix-terms-of-use-array branch February 26, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AADConditionalAccess expects Terms of Use to post as Array of TermsofUse id not single ID
3 participants