You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect the behavior of testInfo.attach() and testInfo.attachments.push() is consistent: both produce equal reporter data structure.
Actual behavior
testInfo.attach() adds extra step attach "foo-attach"
testInfo.attachments.push() does not add extra step attach "foo-push", it stores attachment directly in step.attachments.
Additional context
I've read the discussion in #34037 but still not sure, is it expected behavior with new step.attachments field.
In Playwright 1.49 both methods of adding attachments behave equally.
Maybe it's worth highlighting the difference in the docs.
Last Good Version
1.49
First Bad Version
1.50
Steps to reproduce
Follow the steps in https://github.com/vitalets/playwright-issues/tree/testinfo-attachments-consistency.
Actually it uses test example from #34037, this test.
Expected behavior
I expect the behavior of
testInfo.attach()
andtestInfo.attachments.push()
is consistent: both produce equal reporter data structure.Actual behavior
testInfo.attach()
adds extra stepattach "foo-attach"
testInfo.attachments.push()
does not add extra stepattach "foo-push"
, it stores attachment directly instep.attachments
.Additional context
I've read the discussion in #34037 but still not sure, is it expected behavior with new
step.attachments
field.In Playwright 1.49 both methods of adding attachments behave equally.
Maybe it's worth highlighting the difference in the docs.
Environment
The text was updated successfully, but these errors were encountered: