[Bug]: Line 38 in teams.utils.get_used_citations will raise "AttributeError: 'dict' object has no attribute 'position'"

[frankqianms]

Language

Python

Version

latest

Description

The dict object of citation will raise no attribute position if use citation.position.
if str(citation.position) == match: ^^^^^^^^^^^^^^^^^ AttributeError: 'dict' object has no attribute 'position'

Reproduction Steps

1.
...

[Nivedipa-MSFT]

@frankqianms - Thank you for reaching out! To assist you better, could you please provide a detailed description of the steps you took to encounter the issue?

[frankqianms]

@frankqianms - Thank you for reaching out! To assist you better, could you please provide a detailed description of the steps you took to encounter the issue?

I wrote my own SAY_COMMAND in my bot: https://github.com/[frankqianms/custom-datasource-py](https://github.com/frankqianms/custom-datasource-py). If I import get_used_citations from teams.utils.citations, the bug occurs. So I rewrote the method.

[Nivedipa-MSFT]

@frankqianms - We are not quite clear on your issue. Are you developing any Teams app? If yes, could you please share the repro steps to try at our end. Your shared link is not accessible at our end.

[lilyydu]

Hey @frankqianms,

This seems like a key-access error with the Dict. I believe using brackets should do the trick- noticed you implemented this fix here
https://github.com/frankqianms/custom-datasource-py/blob/main/src/custom_say_command.py#L27

Did this resolve for you?

[frankqianms]

@lilyydu - Yes, it works.

[lilyydu]

@frankqianms Thanks for checking. Would you be open to filing a quick PR fix for this when you get the chance?

[frankqianms]

@lilyydu I can take a try. And besides the get_used_citations codes, any related test cases need to be modified?

[lilyydu]

@frankqianms That would be greatly appreciated, thank you! There might be some tests in test_streaming_response.py - but should be simple + quick

[frankqianms]

@lilyydu Created a pr: #2327

[frankqianms]

@lilyydu After some checks, I closed the pr: #2327. The attributeError occurs when I manually format the citation as a dict type. I belive the planner will return a correct ClientCitation type so that there is no need to do this.