Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when accessing cluster with older API version #135

Open
hansenms opened this issue Aug 16, 2024 · 2 comments
Open

Unexpected behavior when accessing cluster with older API version #135

hansenms opened this issue Aug 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hansenms
Copy link
Contributor

hansenms commented Aug 16, 2024

When trying to search buffers in a 0.5.3 cluster with CLI since v0.6.0, tyger buffer list no longer searches by tag.

To reproduce, run the following script

#!/bin/bash

buf1=$(tyger buffer create --tag mytag=myval)
buf2=$(tyger buffer create)
buf_search=$(tyger buffer list --limit 1 --tag mytag=myval | jq -r '.[0].id')

echo "buf1: $buf1"
echo "buf2: $buf2"
echo "buf_search: $buf_search"

if [ "$buf1" != "$buf_search" ]; then
    echo "Buffer search failed"
    exit 1
fi

echo "Buffer search succeeded"

It succeeds with v0.5.3 and fails with v0.6.0 and later.

The issue here is that we updated the API.

@hansenms hansenms added the bug Something isn't working label Aug 16, 2024
@hansenms
Copy link
Contributor Author

Actually the problem here is that we change the API from tag.<tagname> to tag[<tagname> so that we would have an openAPI compatible schema for code generation. So I think the issue is that maybe there should perhaps be a check, the API versions are not compatible. This causes some unexpected behavior when using a new client with a not updated cluter.

@hansenms hansenms changed the title tyger buffer list no longer respects tags Unexpected behavior when accessing cluster with older API version Aug 16, 2024
@hansenms hansenms added enhancement New feature or request and removed bug Something isn't working labels Aug 16, 2024
@hansenms
Copy link
Contributor Author

We should maybe have a version check in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant