Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline SBInfo allocations & serialization #2094

Open
kamronbatman opened this issue Jan 27, 2025 · 0 comments
Open

Streamline SBInfo allocations & serialization #2094

kamronbatman opened this issue Jan 27, 2025 · 0 comments

Comments

@kamronbatman
Copy link
Contributor

  1. Currently SBInfo is not serialized, but information about it is used to serialize BaseVendor. We should strive keep serialization standardized by rewriting BaseVendor serialization.
  2. SBInfo is copied for every vendor even though 99%+ use a static list. This means as a vendor is spawned, changes maps, barkeep title is changed, etc, the list is recreated which has ramifications for serialization.

Let's architect a way to maintain the serialization of SBInfo that have doubled on a vendor, but avoids additional allocations for SBInfo per vendor where possible. It looks like the double factor is the only thing serialized for vendors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant