Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFI devices: GPIO config seems wrong #498

Open
185264646 opened this issue Feb 16, 2025 · 2 comments
Open

UFI devices: GPIO config seems wrong #498

185264646 opened this issue Feb 16, 2025 · 2 comments

Comments

@185264646
Copy link
Contributor

For UFI001c and jz0145. The device tree configured the EDL button to be pull up and active_low, which is likely to be wrong, and is different with zhihe-various node.

gpios = <&tlmm 37 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;

should be ACTIVE_HIGH and pull down as already defined in zhihe-various node.

@TravMurav

@rcky844 Have you tested the key before?

@rcky844
Copy link

rcky844 commented Feb 17, 2025

This is interesting, because EDL button was working for me.

I can't confirm it now that my unit is broken, so if most people's JZ0145 doesn't work, you can fix it. But please do not blindly fix it by following zhihe-various.

@185264646
Copy link
Contributor Author

This is interesting, because EDL button was working for me.

I can't confirm it now that my unit is broken, so if most people's JZ0145 doesn't work, you can fix it. But please do not blindly fix it by following zhihe-various.

It's inconsistant with https://lore.kernel.org/all/[email protected]/ . Please check it. Either lk2nd or linux dts must be wrong. The button can not be active high in linux while active low in lk2nd. How did you verify that the button works in lk2nd?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants