Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Rename positionStrategy prop to positionMethod #518

Closed
michaldudak opened this issue Aug 2, 2024 · 1 comment · Fixed by #704
Closed

[core] Rename positionStrategy prop to positionMethod #518

michaldudak opened this issue Aug 2, 2024 · 1 comment · Fixed by #704
Labels
core Infrastructure work going on behind the scenes

Comments

@michaldudak
Copy link
Member

michaldudak commented Aug 2, 2024 •
edited
Loading

@colmtuite:
I have a suggestion to rename positionStrategy to positionMethod. It's just a language thing. "Strategy" seems more about a path to achieving a goal/vision. Whereas "method" seems more about a procedure for approaching something. So, to me, "method" is more appropriate here.
@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Aug 2, 2024
@michaldudak michaldudak mentioned this issue Oct 4, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Rename positionStrategy to positionMethod michaldudak/base-ui
1 participant
@michaldudak