-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve/remove delayType
#654
Comments
I don't believe the Wacom issue is a problem since hoverable popovers open on click as well, which the pen input should trigger |
It is an issue though with tooltips and preview cards; also when you frequently use mouse and are used to expect a hover interaction on certain popovers and menus. This is from my own first-hand experience. |
These only support
Can you clarify this? Why would you expect hover to work when not using a hover capable input? Maybe a better solution to handle hover tremors is to use a fallback delay that's ~2-3x as long as the rest delay, ensuring it always opens eventually even if the pointer is constantly moving to some degree? Mainly because it's hard to determine a heuristic that will handle all cases well, while a fallback delay is guaranteed to work. For instance, this seems to work okay from my rough testing, but it's likely not going to cover all possible tremors; a fallback delay does however. event.movementX ** 2 + event.movementY ** 2 < 2 |
@atomiks Wacom tablets work more like a mouse than anything else, with the pointer moving as you hover with the pen over the tablet. They do report
It might be too implicit/arbitrary? Like at 2-3x rest delay you are probably better off clicking anyway? |
@vladmoroz yeah my confusion was thinking Wacom tablets worked like iPad stylus where you press the screen. I remember using one in 2014 but completely forgot about it. PR: floating-ui/floating-ui#3073 |
This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue. |
Instead of
delayType
prop, implement a heuristic to discount insignificant movement during thedelay
phase.It should be easy to open hover popovers when using a Wacom tablet (hard to hold the pen perfectly steady), or if you have a slight hand tremor.
The text was updated successfully, but these errors were encountered: