Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accordion] Support "hidden=until-found" pattern #702

Closed
oliviertassinari opened this issue Oct 3, 2024 · 3 comments · Fixed by #577
Closed

[accordion] Support "hidden=until-found" pattern #702

oliviertassinari opened this issue Oct 3, 2024 · 3 comments · Fixed by #577
Assignees
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request priority: low To delay as much as possible

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 3, 2024

Summary

The hidden="until-found" attribute isn't widely available yet: https://caniuse.com/mdn-html_global_attributes_hidden_until-found_value but it would be great to plan its support. It's better UX. https://developer.chrome.com/docs/css-ui/hidden-until-found for more details

We also have something related to not mounting children to save performance https://mui.com/material-ui/react-accordion/#performance, and this would be another part of the tradeoff for developers when deciding which path they take.

Examples

Search keywords: -

@oliviertassinari oliviertassinari added component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer priority: low To delay as much as possible labels Oct 3, 2024
@oliviertassinari oliviertassinari changed the title [accordion] Support hidden=until-found pattern [accordion] Support "hidden=until-found" pattern Oct 3, 2024
@colmtuite
Copy link
Contributor

@oliviertassinari It's already supported in our Accordion component.

@oliviertassinari
Copy link
Member Author

@colmtuite I have linked this issue with its PR 4 minutes before you commented 👍.

I noticed this issue while I was browsing with Jose the tiptap pricing page and got frustrated I couldn't search in their FAQ accordion https://tiptap.dev/pricing.

@colmtuite colmtuite removed their assignment Oct 4, 2024
@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 6, 2024
@mj12albert mj12albert self-assigned this Oct 15, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: accordion This is the name of the generic UI component, not the React module! new feature New feature or request priority: low To delay as much as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants