Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Rename positionStrategy to positionMethod #704

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[core] Rename positionStrategy to positionMethod #704

merged 1 commit into from
Oct 4, 2024

Conversation

michaldudak
Copy link
Member

Closes #518

@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. labels Oct 4, 2024
@mui-bot
Copy link

mui-bot commented Oct 4, 2024

Netlify deploy preview

https://deploy-preview-704--base-ui.netlify.app/

Generated by 🚫 dangerJS against 3b58930

@michaldudak michaldudak merged commit feb9a05 into mui:master Oct 4, 2024
22 checks passed
@michaldudak michaldudak deleted the positionMethod branch October 4, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite colmtuite approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] Rename positionStrategy prop to positionMethod
3 participants
@michaldudak @mui-bot @colmtuite