[core] Remove delayType prop across hoverable popup components
#730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
Signed-off-by: atomiks <[email protected]>
github-actions
bot
added
PR: out-of-date
vladmoroz
approved these changes
Oct 15, 2024
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654. Now all hoverable popups only open once the cursor is at "rest". As before with
rest, they can never open when scrolling and the cursor happens to land on a trigger, sincemousemoveisn't triggered in that case.@floating-ui/[email protected]will ignore insignficant movements forrestMsonce it's released (allows small 1px movements to handle tremors that are also considered to be "at rest"), but is not tied to this PR.