[core] Refactor popup component style hooks to data-popup-open, data-open
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
changed the title
data-popup-open, data-open
Netlify deploy preview |
atomiks
commented
Oct 10, 2024
vladmoroz
approved these changes
Oct 15, 2024
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717
Style hooks refer to themselves or closely related components:
Triggerreceivesdata-popup-openBackdrop,Popup,Positionerand child components receivedata-opendata-radioitem->data-{checked,unchecked}data-checkboxitem->data-{checked,unchecked}React.useMemothe ownerState for missing componentsdata-entering/data-exitingconsistent