Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIgnInPage] Add default title #4621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap added the core Infrastructure work going on behind the scenes label Jan 20, 2025
@mui-bot
Copy link

mui-bot commented Jan 20, 2025

Netlify deploy preview

https://deploy-preview-4621--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 94fa3ec

@Janpot
Copy link
Member

Janpot commented Jan 20, 2025

should be okay with React 19

Don't we also support React 18 still?

@bharatkashyap bharatkashyap changed the title [core] Fix minor issues [core] Add default title Jan 20, 2025
@bharatkashyap
Copy link
Member Author

should be okay with React 19

Don't we also support React 18 still?

An option could be to set in a useEffect with `document.title = "Sign In"

@bharatkashyap bharatkashyap changed the title [core] Add default title [SIgnInPage] Add default title Jan 20, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignInPage is missing a title .gitignore has tabs
3 participants