-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Start daemon (murmurd) without starting (virtual) servers #4183
Comments
I don't know much about the murmur internals, but I did a test with my murmur server. I stopped virtual servers via murmur-cli. Then I restarted the daemon. All virtual server were running again. I'm not convinced that it is a good solution to have murmurd running in the background when no virtual server is active, just in case the user wants to start a server. On the other hand I think an "autostart" option would be useful (autostart=true/false). That would allow the admin to disable virtual servers and to prevent startup of specific virtual servers when murmurd is (re-) started. I'm talking about an "autostart" option in murmur.ini and the virtual server config. What about "Start daemon without starting virtual server" for the title of this issue? |
I agree that having murmur running in the background doing nothing is not the best idea. Also making this the default breaks any usage of a server binary directly as this relies on the server firing up a virtual server by default. I think it'd be easy enough though to add a CLI option to stop automatic booting of virtual servers. Is that basically what you're asking for? |
I'm not sure that a CLI option is that useful. Wouldn't it make the setup (in Debian) even more complicated? |
I have no idea how the setup works in Debian. But I always thought that every way of starting an application on Linux basically allows to specify CL arguments 🤔 |
tldr: A config option in the configuration files would be best 😃. Because the best case imo would be an option to ask the user during installation about it. Update:
Also: So I guess the best way would be a key in the configuration files. |
Can you clarify what the use case is for this? Is there an actual user asking for this or is this "in case someone ever wants this"? |
Most daemons are indeed started and enabled on install in Debian. The mumble-server package is no exception. I just installed it on Debian Buster and murmurd is running. |
Ah, I guess I was thinking of another distro then. I still don't understand why users that need a one-off instance of murmur wouldn't just disable the service and start/stop it manually though like they do with other software. And I'm still not sure how making murmurd start without provisionning a default virtual server would help with that. |
Btw, murmur-user-wrapper is independent from the system-wide murmurd that is started by systemd. |
@bendem I don't see the need for the use case neither. murmur-user-wrapper seems to work fine for murmurd on-demand instances started by the user. If it's not good enough / easy enough it could be improved, but it doesn't need any change in murmurd itself. Giving the user the option to disable murmurd on install is Debian specific. I think my idea of autostart=true/false is another use case and feature request. |
Well exactly this scenario (on-off with systemd and configuration files in /etc) is inconvenient.
That was one of my questions.
That is the first idea. |
Still starting the daemon without running virtual servers can be a good idea. |
yes
yes output from netstat:
and ps:
|
I still don't see this as something we need (especially considering that we have way too few devs to work on other feature requests already). Even if someone wants to configure their server via ICE, there's no problem whatsoever if there already is a server running when connecting to the ICE interface, 'cause you can simply shut it down again if you don't want it. Or even simpler: You go ahead and configure the server that's already running instead of explicitly starting one yourself. As such I'll close this issue (for now) |
I think that it can be useful. I understand that you want to close issues, but other projects use labels like |
Well starting all existing servers is in fact a feature - it has been explicitly programmed that way and I think this is reasonable. Besides: With this amount of issues and this few developers, low priority is basically the same thing as wontfix 🤷 |
I think this might be a part of the whole gRPC-topic and also related to #4164 . |
How is that related to gRPC?
I have no problem with adding it as a CLI parameter. I'm just really against this being the default behavior. |
Well the whole thing gRPC and stuff is about is virtual server management.
Who said something about default behaviour? |
@streaps did:
and you (I thought at least) did as well:
Because gRPC doesn't care about whether or not a server is already running. |
😕 I don't see how that can be interpreted as arguments for default behaviour.
And? I think that this option would be useful for the proper use of grpc. |
And I disagree. To me this sounds a bit like "You can use a pen to write something on paper. Therefore the paper should be red". Like yeah pen and paper have something to do with each other but that doesn't affect them in such a way. Anyways - this is not the important bit here ^^
🤷 So the consensus here was basically that a config option would be best? |
This was my proposal:
so we would have autostart=true|false in murmur.ini as the default value and you could change that setting for every virtual server (as usual). But honestly, it's not that important. +1 to "With this amount of issues and this few developers, low priority is basically the same thing as wontfix" |
Adding a new config option is not much work at all. My argumentation against this really was because I thought you'd wanted to change the default behavior which would have required a lot of workaround to keep other stuff working. I added the respective option (plus a bonus one) in #4233 |
Closing in favor of #5924 |
Description:
On many Distributions (Linux) the daemon (murmurd) is auto-started on system-startup.
This is intended and useful in most cases and can likely be disabled.
But in some cases people might not want the (or all) virtual servers to also auto-start.
For example if they prefer to configure the virtual servers over protocols like ICE/gRPC etc.
A config option to prevent autostart of (specific) virtual servers in the configuration files would be useful.
Todo:
Update: The initial intended usecase can be solved in a different way, so I changed the description for a different usecase.
The text was updated successfully, but these errors were encountered: