Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace microphone (de)activation noises that are made with generated noise #5891

Open
hvanmegen opened this issue Sep 17, 2022 · 4 comments
Labels
client feature-request This issue or PR deals with a new feature

Comments

@hvanmegen
Copy link

Context

This is not so much a feature as it is a replacement for the currently used samples for the on- and off-sounds for the microphone.

Description

Right now, Mumble uses frequency sweeps going up and down for the respective 'microphone on' and 'microphone off' signal.

I suggest replacing these with samples containing EQ'ed generated noise. Higher pitched noise for the on-signal, and lower pitched noise for the off-signal, pretty much like it is done in Teamspeak3, where the effect resembles the activation and deactivation of actual real-life portophones.

Mumble component

Client

OS-specific?

No

Additional information

No response

@hvanmegen hvanmegen added feature-request This issue or PR deals with a new feature triage This issue is waiting to be triaged by one of the project members labels Sep 17, 2022
@hvanmegen
Copy link
Author

I have created a pull request for this which replaces the original sounds while keeping the old sound effects as renamed files: #5892

@hvanmegen
Copy link
Author

Working on a new pull request that can fix this based on the feedback I got

@Krzmbrzl Krzmbrzl added client and removed triage This issue is waiting to be triaged by one of the project members labels May 13, 2023
@hvanmegen
Copy link
Author

hvanmegen commented Jul 19, 2023

I've created new on_noise.ogg and off_noise.ogg samples, and I've renamed the original on.ogg -> on_sweep.ogg and the off.ogg -> off_sweep.ogg.

I'm terribly sorry, but I have no clue on how I could set up these samples as a default into Mumble myself other than moving a file in a directory and changing the src/mumble/mumble.qrc file..

I'll try to have another stab at it with the comment I got @ #5892 (comment) but the last time I tried, I couldn't get it to work and I kinda got stuck there 😓

samples.zip

@hvanmegen
Copy link
Author

hvanmegen commented Jul 19, 2023

I did my best, sorry if my commit messages were not entirely up to spec.. #6181

Is there any way of setting them up as a default, so all it takes is just enabling the (de)activation sounds in the settings and having these selected by default (with the old sweeps as fallback) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

No branches or pull requests

2 participants