Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite Servers File Directory & Encryption #5937

Open
trymeouteh opened this issue Oct 21, 2022 · 5 comments
Open

Favorite Servers File Directory & Encryption #5937

trymeouteh opened this issue Oct 21, 2022 · 5 comments
Labels
client feature-request This issue or PR deals with a new feature good first issue Good for first-time contributors

Comments

@trymeouteh
Copy link

Context

The ability to store your favorite servers into a file and choose were this file is stored on your computer.

Description

To have a setting on where your favorite server file is stored on your computer. When you add, edit or remove a favorite server, it will modify this file. And to have a setting to set a password for this favorite file to encrypt the data in the file which the mumble client can decrypt.

The reason I would like to request the favorites server becoming a file is for syncing and for backing up. Those who use cloud storage providers such as Google Drive. OneDrive, Dropbox. Sync.com, Filen or even P2P folder syncing like Syncthing can have their favorite servers always backuped to the cloud and synced with their other computers running mumble.

This way users can easily setup an automatic backup of their favorite server which is simular to a "contact list" on your phone. Many people use their Apple ID, Google Contacts or EteSync to sync their contacts and backup their contacts.

By having the favorite servers saved to a file were the user can choose its directory, mumble does not need to create a syncing favorite server feature or service or a backup feature for favorite servers. Users can choose how to sync or backup their favorite server list.

By having the optional password to encrypt the file would help keep the favorite server list details private when users choose to backup their favorite server list onto non-private cloud storage providers such as Google Drive.

Mumble component

Client

OS-specific?

No

Additional information

No response

@trymeouteh trymeouteh added feature-request This issue or PR deals with a new feature triage This issue is waiting to be triaged by one of the project members labels Oct 21, 2022
@Krzmbrzl
Copy link
Member

Well technically the favorite servers are already stored in a file: The client's database ^^

But that won't really cut it in your scenario.

@Krzmbrzl Krzmbrzl added client good first issue Good for first-time contributors and removed triage This issue is waiting to be triaged by one of the project members labels Oct 21, 2022
@dihernandez
Copy link

I'd like to give it a shot

@Krzmbrzl
Copy link
Member

@dihernandez awesome! Do you need some hints on where to start?

@dihernandez
Copy link

Yes Please

@Krzmbrzl
Copy link
Member

@dihernandez Sorry for the late reply - I was (and still am) very busy 👀

First of all, you should have a look at https://github.com/mumble-voip/mumble/blob/master/docs/dev/TheMumbleSourceCode.md

and then for this issue in particular, https://github.com/mumble-voip/mumble/blob/master/src/mumble/ConnectDialog.cpp is the class that seems most relevant. In particular what is going on in its destructor and when it is loading the favorite servers (somewhere during construction/initialization).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature good first issue Good for first-time contributors
Projects
None yet
Development

No branches or pull requests

3 participants