Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client to bind to specific IP address+port (VPN) #5938

Open
trymeouteh opened this issue Oct 21, 2022 · 4 comments
Open

Allow client to bind to specific IP address+port (VPN) #5938

trymeouteh opened this issue Oct 21, 2022 · 4 comments
Labels
client feature-request This issue or PR deals with a new feature

Comments

@trymeouteh
Copy link

Context

Adding a network interface setting into the Mumble client and Mumble server.

Description

I recently discovered that qBittorrent essentially has a VPN Kill Switch feature built into the client which will kill its connection if it detects your VPN has disconnected. VPN kill switches from VPN clients for the desktop are not fully reliable as they can often fail and you can still connect to the internet with a unencrypted connection with your IP exposed.

I would like to purpose adding this feature in the settings for both the Mumble client and Mumble server. This way if your VPN disconnects, The client and/or server will also lose internet access too. There has been many times my VPN disconnects without me knowing while I was browsing the web.

Mumble component

Both

OS-specific?

No

Additional information

Sometimes I do host a mumble server over a VPN since my VPN supports port forwarding. Having a setting in the INI file for network interface would be useful also.

@trymeouteh trymeouteh added feature-request This issue or PR deals with a new feature triage This issue is waiting to be triaged by one of the project members labels Oct 21, 2022
@davidebeatrici
Copy link
Member

Technically it's not a kill switch: the setting simply allows to bind the application to a specific interface (IP address) on the system.

; Specific IP or hostname to bind to.
; If this is left blank (default), the server will bind to all available addresses.
;host=

We can easily implement it for the client too.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Oct 21, 2022

I would argue that this should be the job of your VPN client and not the job of Mumble.

If your VPN client is not reliable in this, use a different one.

I'm arguing against implementing this in Mumble as the code is already complex enough and by keep adding features to it that technically don't belong into it's responsibilities, this will only worsen the situation (mind you: even if implementing itself is easy, it's the long term maintenance that I am concerned with)

@davidebeatrici
Copy link
Member

No maintenance burden involved: we simply allow the user to bind the socket(s) we use to a specific IP address and/or port.

An actual kill switch would indeed be the job of the VPN client or, more specifically, the operating system's routing table.

@Krzmbrzl
Copy link
Member

Well, if this is as simple as you make it sound, I'd be okay with that.

@Krzmbrzl Krzmbrzl changed the title VPN Kill Switch (Network Interface setting) Allow client to bind to specific IP address+port (VPN) Oct 21, 2022
@Krzmbrzl Krzmbrzl added client and removed triage This issue is waiting to be triaged by one of the project members labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

No branches or pull requests

3 participants