Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX(Client): register const void * #6736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX(Client): register const void * #6736

wants to merge 1 commit into from
+1 −1

Conversation

MaxNarr
Copy link

@MaxNarr MaxNarr commented Feb 25, 2025 •
edited by Krzmbrzl
Loading

Added metatype registration of const void *
previously audio output wasn't working correctly due to forgotten registration in ca87877

Closes #6735

@Hartmnt
Copy link
Member

Hartmnt commented Feb 25, 2025

Could you please update the commit message? It is missing a : after the ).

Git commands:
git commit --amend
git push myfork fixing --force-with-lease

@MaxNarr MaxNarr changed the title FIX(Client) register const void * FIX(Client): register const void * Feb 25, 2025
@Hartmnt Hartmnt added client audio bug A bug (error) in the software labels Feb 25, 2025
@Krzmbrzl
Copy link
Member

Could we change the commit message to state intent rather than implementation? That is, to something like FIX(client): Audio output never reactivating after silence and then in the actual commit message body mention how it was achieved (including a reference to ca87877). So overall, I would suggest a message such as

FIX(client, audio): Audio output never reactivating after silence

Since ca87877a56067bf62a3adaa58736e76eb270ece8 once the audio output has stopped even
just momentarily, it would remain inactive with an error message about const void * not being
registered as a Qt metatype.

This commit fixes the issue by explicitly registering const void * to Qt, which makes it usable in Qt's
signal/slot mechanism so that it no longer fails. A working signal/slot mechanism implies that the
audio processing remains intact and thus continues to play audio output.

Fixes #6735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartmnt Hartmnt Hartmnt approved these changes

Assignees
No one assigned
Labels
audio bug A bug (error) in the software client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audio output stops working
3 participants
@MaxNarr @Hartmnt @Krzmbrzl