From 48cbdb955512add63e3c97598a3417082cf587b1 Mon Sep 17 00:00:00 2001
From: Isabela Case <igoes@Isabelas-MacBook-Air.local>
Date: Sat, 1 Jul 2023 16:48:01 -0500
Subject: [PATCH 1/3] chore: add script to collect miri logs

---
 scripts/get-miri-logs.sh | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100755 scripts/get-miri-logs.sh

diff --git a/scripts/get-miri-logs.sh b/scripts/get-miri-logs.sh
new file mode 100755
index 00000000..07415f1d
--- /dev/null
+++ b/scripts/get-miri-logs.sh
@@ -0,0 +1,19 @@
+#!/bin/bash
+
+# This script collect logs for running Miri in each crate
+# Note: Needs Miri installed to run
+
+mkdir ../.logs
+cd ../crates
+cargo clean
+
+for directory in * ; do
+    echo "$directory"
+    OUTPUT_FILE=../.logs/log_$directory
+    MIRIFLAGS="\
+    -Zmiri-disable-stacked-borrows \
+    -Zmiri-backtrace=full \
+    -Zmiri-disable-isolation" \
+    RUST_BACKTRACE=full \
+    cargo +nightly miri test --package $directory --no-fail-fast >> $OUTPUT_FILE 2>&1
+done

From 182a595ab008bb5f4651ed08deaa4b85f34b9c94 Mon Sep 17 00:00:00 2001
From: Isabela Case <igoes@Isabelas-MacBook-Air.local>
Date: Sat, 1 Jul 2023 16:55:51 -0500
Subject: [PATCH 2/3] chore: add install line in script

---
 scripts/get-miri-logs.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/scripts/get-miri-logs.sh b/scripts/get-miri-logs.sh
index 07415f1d..c1f60323 100755
--- a/scripts/get-miri-logs.sh
+++ b/scripts/get-miri-logs.sh
@@ -1,7 +1,10 @@
 #!/bin/bash
 
 # This script collect logs for running Miri in each crate
-# Note: Needs Miri installed to run
+# Note: Needs Miri installed to run or uncomment the line to install it
+
+# Install Miri
+#rustup +nightly component add miri
 
 mkdir ../.logs
 cd ../crates
@@ -14,6 +17,5 @@ for directory in * ; do
     -Zmiri-disable-stacked-borrows \
     -Zmiri-backtrace=full \
     -Zmiri-disable-isolation" \
-    RUST_BACKTRACE=full \
     cargo +nightly miri test --package $directory --no-fail-fast >> $OUTPUT_FILE 2>&1
 done

From 5bf6d7548990e7ae49a56df08e8da72a722b578d Mon Sep 17 00:00:00 2001
From: Wodann <Wodann@users.noreply.github.com>
Date: Tue, 19 Dec 2023 17:25:15 +0000
Subject: [PATCH 3/3] misc: apply review suggestions

---
 scripts/get-miri-logs.sh | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/scripts/get-miri-logs.sh b/scripts/get-miri-logs.sh
index c1f60323..02110761 100755
--- a/scripts/get-miri-logs.sh
+++ b/scripts/get-miri-logs.sh
@@ -1,21 +1,24 @@
 #!/bin/bash
 
 # This script collect logs for running Miri in each crate
-# Note: Needs Miri installed to run or uncomment the line to install it
 
-# Install Miri
-#rustup +nightly component add miri
+# Install nightly Miri
+rustup toolchain install nightly --profile minimal --component miri
 
-mkdir ../.logs
-cd ../crates
+# Create the folder for logs
+mkdir -p .logs
+
+# Run clean to ensure that we get all miri errors
 cargo clean
 
-for directory in * ; do
-    echo "$directory"
-    OUTPUT_FILE=../.logs/log_$directory
+for path in crates/* ; do
+    echo "Running miri in '$path'"
+    package=$(basename "$path")
+    OUTPUT_FILE=.logs/log_$package
     MIRIFLAGS="\
     -Zmiri-disable-stacked-borrows \
     -Zmiri-backtrace=full \
     -Zmiri-disable-isolation" \
-    cargo +nightly miri test --package $directory --no-fail-fast >> $OUTPUT_FILE 2>&1
+    # Log to stdout and a file - for future reference
+    cargo +nightly miri test --package $package --no-fail-fast 2>&1 | tee $OUTPUT_FILE
 done