Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB reader is using dynamoDbParams against documentClient #147

Open
ceilfors opened this issue Jul 3, 2019 · 0 comments
Open

DynamoDB reader is using dynamoDbParams against documentClient #147

ceilfors opened this issue Jul 3, 2019 · 0 comments

Comments

@ceilfors
Copy link
Collaborator

ceilfors commented Jul 3, 2019

Describe the bug
DynamoDB reader for laconia batch is using documentClient, but the params is passed is as dynamoDbParams.

To Reproduce
Create a reader with dynamoDb params ExpressionAttributeValues format:

dynamoDb({
  operation: "QUERY",
  dynamoDbParams: {
    TableName: "Music",
    Limit: 1,
    ExpressionAttributeValues: {
      ":a": { "S": "Bar" }
    },
  }
});

Expected behavior
dynamoDbParams must be renamed to documentClientParams

    ExpressionAttributeValues: {
      ":a": "Bar" 
    },

Actual behavior
The reader would break because of the following code:

    ExpressionAttributeValues: {
      ":a": { "S": "Bar" }
    },

Additional context

This is a breaking change. Deprecate dynamoDbParams instead or removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant