Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Image selector editor list view not working #5430

Open
1 task done
robinroloff opened this issue Jan 9, 2025 · 1 comment
Open
1 task done

BUG: Image selector editor list view not working #5430

robinroloff opened this issue Jan 9, 2025 · 1 comment
Labels

Comments

@robinroloff
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When opening the list view and clicking an image to select it, it doesn't work. Nothing happens

Expected Behavior

When clicking an image, it should be selected as the property

Steps To Reproduce

No response

Environment

No response

Anything else?

The problem is here:

const assetLink = e.target.closest('a[data-asset-identifier], button[data-asset-identifier]');

This query does not check for the closest tag, but the table view uses a .

Another issue I noticed is that the variable "assetLink" is not used at all. Instead, the variable "asset" is used, but I believe the variable "assetLink" should be used.
Also the whole "closest" thing could just be avoided by using event.currentTarget instead of e.target.closest(...). Then, a check for the the data-asset-identifier would not be necessary, as it was already checked before adding the event listener

@dlubitz
Copy link
Contributor

dlubitz commented Jan 9, 2025

Might be introduced with #5117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants