Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importance Classifier: regression as it always classifies, even if turned off #10556

Closed
jurgenhaas opened this issue Jan 11, 2025 · 5 comments · Fixed by #10585
Closed

Importance Classifier: regression as it always classifies, even if turned off #10556

jurgenhaas opened this issue Jan 11, 2025 · 5 comments · Fixed by #10585

Comments

@jurgenhaas
Copy link

Steps to reproduce

There is a regression that mails get classified, although it's completely turned off. This was fixed over a year ago in #5260 and #6390 but that just returned a couple of days ago.

Expected behavior

When the classifier is turned off, it should not classify.

Actual behavior

Although the classifier is turned off, emails get marked as important.

Mail app version

4.2.0-alpha.2

Nextcloud version

30.0.4

Mailserver or service

Mailcow

Operating system

Ubuntu

PHP engine version

PHP 8.3

Nextcloud memory caching

No response

Web server

Apache (supported)

Database

MariaDB

Additional info

No response

@kesselb
Copy link
Contributor

kesselb commented Jan 13, 2025

cc @st3iny

@st3iny st3iny self-assigned this Jan 13, 2025
@st3iny
Copy link
Member

st3iny commented Jan 20, 2025

I tested it and the backend is fine. I noticed however, that the settings UI is showing the incorrect state. So, the importance is likely still enabled despite you having disabled it.

You can check via the following SQL query:
select configvalue from oc_preferences where appid = 'mail' and userid = 'admin' and configkey = 'tag-classified-messages';

(Replace admin with the id of your user.)

@jurgenhaas
Copy link
Author

Interesting, thanks @st3iny

I've tested this, and it turns out, there isn't any value set for tag-classified-messages for any of the users on that instance.

I'm now adding it and see if that makes any difference.

@st3iny
Copy link
Member

st3iny commented Jan 20, 2025

I'm now adding it and see if that makes any difference.

Yeah, that is fine and makes sense because the default value is true (if the config is not existing). Meaning, the classification is enabled by default if the user never toggled the config.

@jurgenhaas
Copy link
Author

This seems to have resolved this issue, haven't seen any classified email for a couple of days. Thanks @st3iny for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants