Can't get cats to give gifts

[hahaluckyme]

I play on a server that uses Harbor to skip the night, but I have been unsuccessful at getting cats to give gifts after sleeping. This blocks obtaining phantom membranes on servers that turn off nighttime phantoms.
https://minecraft.fandom.com/wiki/Cat#Gifts

My suspicion is that the non-instant version of skipping the night is interfering with cats being able to give a gift, but I'm not able to confirm it. Is this something that's been considered already?

[nkomarn]

Honestly didn't even know about this vanilla feature.

I can look into the vanilla server code and check which exact conditions are being checked for gift giving and see if Harbor conflicts.

[hahaluckyme]

Thanks! Yeah, I only found it about it a few days ago, seems like it's not really well known. Just from looking at the code briefly, it looks like calling setTime in small increments acts more like normal passage of time and overlooking the night skipping logic.

harbor/src/main/java/xyz/nkomarn/harbor/task/AccelerateNightTask.java

Line 49 in 5aaa039

world.setTime(time + (int) timeRate);

[hahaluckyme]

After further investigation, you need to set the TimeSkipEvent reason to be NIGHT_SKIP and not COMMAND.

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/world/TimeSkipEvent.SkipReason.html

[hahaluckyme]

Something like this at the very end of the skip cycle

TimeSkipEvent event = new TimeSkipEvent(worldserver.getWorld(), TimeSkipEvent.SkipReason.NIGHT_SKIP, 0);
Bukkit.getPluginManager().callEvent(event);

[nkomarn]

Looks like the time of day and player sleep counter need to be between a specific range for the gifts logic to run.