-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request permission to create personal and Jenkins tokens for github-bot
add Secrets to nodejs/reliability
and nodejs/node
#523
Comments
+1 |
In theory this requires two approvals from TSC and CommComm (per our GitHub management policy), although until yesterday the policy for adding secrets was unspecified. So ping @nodejs/tsc @nodejs/community-committee. |
+1 |
Sorry for the constant pings, but this still needs two other approvals per our policy. @nodejs/tsc @nodejs/community-committee |
+1, no apology necessary <3 |
+1 |
1 similar comment
+1 |
Thanks! I started to add the secrets, but apparently github-bot doesn't have all the permissions it needs on Jenkins (nodejs/reliability#26). I'll wait until we add those permissions to it before finishing this task. |
All secrets were added. |
I noticed we don't have a policy to create tokens for
github-bot
nor do we have a policy to add Secrets (which are used by Actions) to repositories, so I'll assume the same requirements we have for creating GitHub Apps (because functionally creating token + adding secrets is similar to creating an App). This issue bundles a few requests:For
nodejs/reliability
@nodejs-github-bot
@nodejs-github-bot
withrepo.public_repo
anduser.read:user
scopesnodejs/reliability
repository:JENKINS_TOKEN
(with the Jenkins token generated above),USER_TOKEN
(with the personal access token generated above) andUSER_NAME
(withnodejs-github-bot
)These tokens will be used by the
nodejs/reliability
Actions to generate daily reports of all failures in our CI. The reports are generated viancu-ci
.Ref: nodejs/reliability#24 and nodejs/reliability#25
For
nodejs/node
@nodejs-github-bot
@nodejs-github-bot
withrepo.public_repo
anduser.read:user
scopesnodejs/reliability
repository:JENKINS_TOKEN
(with the Jenkins token generated above),GH_USER_TOKEN
(with the personal access token generated above) andGH_USER_NAME
(withnodejs-github-bot
)These tokens will be available for any Actions running on
nodejs/node
, except for Actions running on the scope of Pull Requests from forks (so a PR with a malicious actions does not have access to those tokens). Initially, these tokens are intended to be used onCommit Queue
andStart CI via Label
Actions, but it will be available for other Actions as well.Ref: Commit Queue and Start CI via Label (both PRs are blocked until the Secrets are added to the repository).
cc @nodejs/tsc @nodejs/community-committee
The text was updated successfully, but these errors were encountered: