citgm-smoker broken on osx13-arm64

[targos]

See for example https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3548/nodes=osx13-arm64/testReport/junit/(root)/citgm/jose/

[richardlau]

The job does this:

find "$NODE_TEST_DIR" -mtime +3 | xargs rm -rf
temp="$NODE_TEST_DIR"/citgm_tmp
rm -rf $temp/* || true
mkdir $temp || true

so presumably NODE_TEST_DIR isn't defined. On other platforms we set the environment variable as part of the Jenkins agent scripts, e.g. for systemd based systems:

build/ansible/roles/jenkins-worker/templates/systemd.service.j2

Line 23 in 9321081

Environment="NODE_TEST_DIR=/home/{{ server_user }}/tmp"

For macOS this used to be done as part of start.sh, which presumably we're no longer running with the new ephemeral set up:

build/ansible/roles/jenkins-worker/templates/start.j2

Lines 2 to 11 in 9321081

	export HOME={{ home }}/{{ server_user }}
	export NODE_TEST_DIR="$HOME/tmp"
	export JOBS="{{ jobs_env }}"
	export OSTYPE=osx
	export ARCH="{{ arch }}"
	export DESTCPU="{{ arch }}"
	# Make sure `brew` is on the PATH to get the location of the ccache symlinks.
	export PATH="/usr/local/opt/python3/Frameworks/Python.framework/Versions/Current/bin:/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
	export PATH="$(brew --prefix)/opt/ccache/libexec:$PATH"

cc @ryanaslett @UlisesGascon

[ryanaslett]

I've added the NODE_TEST_DIR environment variable to the jenkins cloud definitions.

I attempted a re-run but it appears that dir needs to be created and isnt created by the build process. I've changed it to /Users/admin/node-tmp which does exist on those machines. (unless thats some other kind of tmp dir used for other purposes.?)

[ryanaslett]

00:25:47.009 + find /Users/admin/node-tmp -mtime +3
00:25:47.010 + xargs rm -rf
00:25:47.012 + temp=/Users/admin/node-tmp/citgm_tmp
00:25:47.012 + rm -rf '/Users/admin/node-tmp/citgm_tmp/*'
00:25:47.013 + mkdir /Users/admin/node-tmp/citgm_tmp
00:25:47.014 mkdir: /Users/admin/node-tmp: No such file or directory
00:25:47.014 + true

the latest rerun seems to be confused. Its saying No such file or directory in the console log, yet.. on the instance itself we see:

admin@macos13-arm-test citgm_tmp % pwd
/Users/admin/node-tmp/citgm_tmp

I believe this is now fixed.