Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real API instead of HTML parsing #13

Open
novel opened this issue Oct 9, 2019 · 2 comments
Open

Use real API instead of HTML parsing #13

novel opened this issue Oct 9, 2019 · 2 comments
Labels
todo

Comments

@novel
Copy link
Owner

novel commented Oct 9, 2019

Apparently, urbandictionary has a real API (again):

http://api.urbandictionary.com/v0/define?term=bebebe
https://api.urbandictionary.com/v0/random

(noticed it here: https://www.npmjs.com/package/urban-dictionary)

Would be good to add implementation that uses this API. Should probably keep HTML parsing code in case API becomes unavailable again.
@novel novel added the todo label Oct 9, 2019
@penn5
Copy link

penn5 commented Nov 11, 2019

I'm gonna make a PR for this because the HTML parsing just broke. It now doesn't get the full text of the example.

@penn5
Copy link

penn5 commented Nov 11, 2019

Actually I'm not; I'm going to use https://github.com/Naught0/asyncurban instead

@Bilibox Bilibox mentioned this issue Jan 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novel @penn5