Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something sensible with schemeless URLs #59

Open
zeke opened this issue Apr 9, 2015 · 3 comments
Open

Do something sensible with schemeless URLs #59

zeke opened this issue Apr 9, 2015 · 3 comments
Labels

Comments

@zeke
Copy link
Contributor

zeke commented Apr 9, 2015

https://github.com/npm/newww/issues/840

Somehow the mobile-detect package made it through the publish process (3 weeks ago) without its broken repository value getting discarded or repaired:

repository: {
  type: "git",
  url: "github.com/hgoebl/mobile-detect.js"
}

http://registry.npmjs.org/mobile-detect

@zeke zeke added the bug label Apr 9, 2015
zeke added a commit to zeke/mobile-detect.js that referenced this issue Apr 9, 2015
@hgoebl
Copy link

hgoebl commented Apr 9, 2015

@zeke do you think I should publish a new version now? Thanks for contributing BTW.

@zeke
Copy link
Contributor Author

zeke commented Apr 9, 2015

@hgoebl yeah go for it.

For the record, 1.0.0 is a version with the not-fully-qualified URL.

@sindresorhus
Copy link
Contributor

I would also like to see the author.url field normalized to have http:// prepended if missing: https://github.com/sindresorhus/debug-log/blob/fb9e716cd288846df5dca4c37baea7c49e8351ec/package.json#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants