Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for "has:bin" #153

Open
blakeembrey opened this issue May 4, 2017 · 4 comments
Open

Add flag for "has:bin" #153

blakeembrey opened this issue May 4, 2017 · 4 comments

Comments

@blakeembrey
Copy link

This could be useful for people who are trying to find a package that provides a CLI counterpart. E.g. has:bin css or has:bin minify.

@satazor
Copy link
Member

satazor commented May 5, 2017

I like it and it would be easy to implement!

@sindresorhus
Copy link

I would go for has:cli css.

@satazor satazor closed this as completed Jan 18, 2019
@satazor
Copy link
Member

satazor commented Jan 18, 2019

Oops closed by mistake. I will be writing here instructions on how to implement this feature in case anyone wants to work on this.

@satazor satazor reopened this Jan 18, 2019
@satazor
Copy link
Member

satazor commented Jan 18, 2019

Here are the instructions:

  1. Add a bin field to the collected metadata here, which can be a direct copy of object defined the package bin field.
  2. Add the bin flag here
  3. Declare the bin field in the Elasticsearch index definition here, which should be a true if the bin object is empty or undefined, and true if it has at least one property
  4. Update the queries module so that it knows how to parse has:bin. Also, has:cli could be made an alias to has:bin

As you see, it should be really easy to add this feature in case anyone want to take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants