-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs board not showing #32
Comments
There are no unexpired jobs! Maybe I should print a message when that is the case? |
Behavior is correct, if undesirable. I can have it filter first and then display. See also #33 |
Oh I see! Thanks @stefanv ! |
It's a good question, how those jobs ever slip by, because the code is: const jobs = filterJobs(jobData, formData); and in const filterJobs = (jobs, filter) => {
// Filter out expired jobs. Use Howland Island timezone to ensure
// that everyone sees the job on its last day.
const today = new Date();
jobs = jobs.filter((job) => new Date(`${job.expires}T23:59:59.999-12:00`) > today);
|
Also, from a UX perspective, the idiomatic pattern would be to always show some kind of message confirming that no open jobs are available instead of just a blank screen, which (as can be seen by the multiple responses here) is interpreted by users as abnormal behavior of unclear provenance. |
Check out the new page ;) |
As one of the confused people by the blank page, the banner is great—thanks! |
Yes, all the jobs are there, since they receive permalinks. I can add a button to the search box to show expired posts as you suggest. |
@psobolewskiPhD There you go: #34 |
They render side-by-side on a wide screen, and then start to wrap as the screen gets narrower. A simple bit of CSS would solve that, if someone wants to take a look. |
we can decrease padding to the right so that full-time come in 1 line |
Currently, the jobs board is actually showing up as empty on https://jobs.numfocus.org/
The console is showing a couple of errors:
The text was updated successfully, but these errors were encountered: