Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Introduce new Intel, AMD and IBM CPU's #978

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

JasperB-TeamBlue
Copy link
Contributor

Changes introduced with this PR

Intel:

  • Sapphire Rapids Server
  • Secure Sapphire Rapids Server
    • added all security feautures mentioned in v2 on qemu

AMD:

  • EPYC-Milan
  • Secure EPYC-Milan
    • added all security feautures mentioned in v2 on qemu
  • EPYC-Rome
  • EPYC-Rome v2
    • added all feautures mentioned in v2 on qemu
  • EPYC-Genoa

IBM:

  • POWER10

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y]

@dupondje
Copy link
Member

dupondje commented Dec 31, 2024

@shubhaOracle @saksham-oracle:
Could you guys check this patch?

I've seen you included a add-sapphire-rapids-server-family.patch in latest Oracle ovirt-engine builds.
But I think that patch is invalid.

-        || '20:Secure Intel Icelake Server Family:vmx,arch-capabilities,rdctl-no,ibrs-all,skip-l1dfl-vmentry,mds-no,pschange-mc-no,model_Icelake-Server-noTSX:Icelake-Server-noTSX,+arch-capabilities,+rdctl-no,+ibrs-all,+skip-l1dfl-vmentry,+mds-no,+pschange-mc-no,-mpx:x86_64; '
+        || '20:Secure Intel Icelake Server Family:vmx,model_Icelake-Server-noTSX:Icelake-Server-noTSX,-mpx:x86_64; '
+        || '21:Intel Sapphire Rapids Server Family:vmx,model_SapphireRapids-Server-noTSX:SapphireRapids-Server-noTSX,-mpx:x86_64; '
+        || '22:Secure Intel Sapphire Rapids Server Family:vmx,arch-capabilities,rdctl-no,ibrs-all,skip-l1dfl-vmentry,mds-no,pschange-mc-no,model_SapphireRapids-Server-noTSX:SapphireRapids-Server-noTSX,+arch-capabilities,+rdctl-no,+ibrs-all,+skip-l1dfl-vmentry,+mds-no,+pschange-mc-no:x86_64; '

You change the flags of Secure Intel Icelake Server Family, and apply the same flags to Secure Intel Sapphire Rapids Server Family.
For Sapphire Rapids you use model_SapphireRapids-Server-noTSX as a base, but that model does not exist in libvirt?! :)

Has this been tested? :)

Also I think it might be better to have a consensus here, cause if flags start to differ between OLVM and oVirt upstream, you might end up with annoying things in the future.

@fraenki
Copy link

fraenki commented Feb 10, 2025

Is there a chance to get this merged/released soon? We're very much looking forward to this change. Thanks!

Intel:
- Sapphire Rapids Server
- Secure Sapphire Rapids Server
	- added all security feautures mentioned in v2 on qemu
AMD:
- EPYC-Milan
- Secure EPYC-Milan
	- added all security feautures mentioned in v2 on qemu
- EPYC-Rome
- EPYC-Rome v2
	- added all feautures mentioned in v2 on qemu
- EPYC-Genoa

IBM:
- POWER10

Signed-off-by: Jasper Berton <[email protected]>
@dupondje
Copy link
Member

Also included in the latest ovirt-engine release of OLVM. Except the POWER10 CPU.

@dupondje dupondje merged commit 8b39c3d into oVirt:master Feb 12, 2025
2 checks passed
@dupondje dupondje deleted the new-cpu branch February 12, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants