Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with React Native Storybook 6.5 #453

Open
tamlyn opened this issue Apr 17, 2023 · 6 comments
Open

Not working with React Native Storybook 6.5 #453

tamlyn opened this issue Apr 17, 2023 · 6 comments

Comments

@tamlyn
Copy link

tamlyn commented Apr 17, 2023

First of all Loki looks 😍 !

But it doesn't seem to support React Native Storybook 6.5 (which was finally released a few weeks ago after years of development).

$ yarn loki init
loki init v0.31.1
Storybook config path not found at "storybook", try passing a --config argument

The new version uses the same .storybook/main.js config file as web storybook, so it may be possible to remove some RN special cases like this:

if (isReactNativeProject) {
const storybookjsPath = `${storybookPath}/storybook.js`;

Aside from superficial changes like this, does anyone have an idea of what will be required to make it work?

@oblador
Copy link
Owner

oblador commented Apr 17, 2023

Hey! I started to looking at it and there were some large internal changes to storybook that broke Loki. I feedback that to the RN SB maintainer who made some changes, I just need to restart this process again and I've been short on time lately. It's a goal to support it 👍 If you're up for it I'd be happy if you took a stab, but I'm not sure if it's trivial as a first contribution,

@slavikdenis
Copy link
Contributor

@oblador I could try to help you out. Do you have some changelog that I could look at and try to support the new changes on RN SB?

@danchen86
Copy link

Hi, I am also having compatibility issues with React NativeStorybook v6.5. Is there a timeline on when it will be supported? Thanks!

@januswel
Copy link

januswel commented Dec 8, 2023

Any workarounds or issues to solve?

@nehahirve92
Copy link

@slavikdenis any updates? I'm happy to help but need some guidance

@nehahirve92
Copy link

or maybe @techeverri can point me where to start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants