Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki is not supporting node 14 but lambda only runs on node 14. #487

Open
thiagodmont opened this issue Nov 13, 2023 · 4 comments
Open

Loki is not supporting node 14 but lambda only runs on node 14. #487

thiagodmont opened this issue Nov 13, 2023 · 4 comments

Comments

@thiagodmont
Copy link
Contributor

We are trying to update our lambdas to node16/18 but unfortunately due to a dependency in @loki/renderer-aws-lambda with chrome-aws-lambda we cannot do this.

This is the issue with the chrome-aws-lambda.

I'd like to know if there is any plans to update the @loki/renderer-aws-lambda, to use a different library for the browser.

Since loki has no support for node14 it would be great to be possible to update the node version on the lambdas as well.

@thiagodmont thiagodmont changed the title Loki is not supporting node 14 but lambda only runs on node14. Loki is not supporting node 14 but lambda only runs on node 14. Nov 13, 2023
@oblador
Copy link
Owner

oblador commented Nov 13, 2023

I'll accept a PR migrating to @sparticuz/chromium per this guide: https://www.npmjs.com/package/@sparticuz/chromium#migration-from-chrome-aws-lambda

@thiagodmont
Copy link
Contributor Author

Great! I'm going to open the PR with the change.

@oblador
Copy link
Owner

oblador commented Nov 13, 2023

Currently lambda tests are using a node 12 image from the dead lambci project, if you feel like it consider using this instead: https://github.com/aws/aws-lambda-runtime-interface-emulator

@thiagodmont
Copy link
Contributor Author

Hey @oblador I created the PR, please let me know if you have any question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants