Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random false positives when testing stories for components that have not been modified #501

Open
squidjam opened this issue Feb 16, 2024 · 1 comment

Comments

@squidjam
Copy link

Hi.
I am using loki 0.34.0 with storybook 7.6.10 and I'm experiencing random instances where the fonts seem to move 1 or 2 pixels, but only on the one story and only sometimes.

I am using pixelmatch with a threshold of 0.3. It's set up to run against a static-storybook generated on a previous pipeline step in Azure DevOps. The static storybook is served using http-server.

It fails randomly, we run the pipeline again, it succeeds.

Is it that I should not use pixelmatch? or that I'm setting the wrong threshold (30% seems generous to me)? or something else that's being looked at?

Thanks

image
image

@squidjam squidjam changed the title Random false positives when testing stories for elements that have not been modified Random false positives when testing stories for components that have not been modified Feb 16, 2024
@repcolding
Copy link

I also have this problem. There are many false positives at each launch, and they are always on different components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants