Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallelism warning from 4.14+ #26585

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Remove parallelism warning from 4.14+ #26585

merged 2 commits into from
Sep 18, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Sep 18, 2024

While clearing the decks for something more important, these diffs were irritating.

The parallelism warning has been mostly removed (note that several of the +options packages from recent releases do not include it). It's highly unlikely to be the root cause, and the suggestion just causes the poor user to waste time and energy on a sequential build.

While here, there are three trivial updates to +trunk packages when building on MSYS2.

Changes to post-messages should not trigger rebuilds 🤞

Parallelism warning isn't helpful, as it's highly unlikely to be the
problem (already removed elsewhere)
@raphael-proust
Copy link
Collaborator

Changes to post-messages should not trigger rebuilds 🤞

"should not" as in "I don't think it will" or "should not" as in "wouldn't it be nice if opam didn't"? I.e., should we open an issue on opam?

@kit-ty-kate
Copy link
Member

Changes to post-messages should not trigger rebuilds 🤞

"should not" as in "I don't think it will" or "should not" as in "wouldn't it be nice if opam didn't"? I.e., should we open an issue on opam?

it will not: https://github.com/ocaml/opam/blob/b9e808bf2aa91e6afca144f46e8547a291c20452/src/format/opamFile.ml#L3597

@mseri mseri merged commit 45f9617 into ocaml:master Sep 18, 2024
1 of 2 checks passed
@mseri
Copy link
Member

mseri commented Sep 18, 2024

Thanks

@dra27 dra27 deleted the trunk-tweaks branch September 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants