Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spread: middlewares: support X-Features header #4

Open
4 tasks
kamilsk opened this issue Jan 10, 2021 · 1 comment
Open
4 tasks

spread: middlewares: support X-Features header #4

kamilsk opened this issue Jan 10, 2021 · 1 comment
Assignees
@kamilsk
Labels
difficulty: medium Issue has medium complexity. kind: feature New feature request. scope: code Issue related to source code. scope: docs Issue related to documentation. scope: test Issue related to tests.

Comments

@kamilsk
Copy link
Member

kamilsk commented Jan 10, 2021 •
edited
Loading

Motivation: add the possibility to work with features more flexible.

Steps:

  • add specific header
req.Header.Set(http.XFeatures, config.Feature{Name, false}.String())
  • extend config module
features.Find -> alias for FindByName

config.Features.Unmarshal(req.Header.Get(http.XFeatures)).Find(needs)
  • context support
ctx = context.WithValue(req.Context, Features, MutatedFeatures)
  • timeout/deadline support
context.Value(Features).Find(Deadline).Enabled -> apply middleware
@kamilsk kamilsk added the help wanted Extra attention is needed. label Jan 10, 2021
@kamilsk kamilsk self-assigned this Jan 10, 2021
@kamilsk
Copy link
Member Author

kamilsk commented Jan 10, 2021 •
edited
Loading

Blocked by octolab/config/issues/3.

@kamilsk kamilsk mentioned this issue Jan 10, 2021
Closed
4 tasks
@kamilsk kamilsk added kind: improvement New improvement proposal. and removed help wanted Extra attention is needed. labels May 11, 2022
@kamilsk kamilsk moved this to Backlog in 🏗 Platform May 11, 2022
@kamilsk kamilsk added scope: docs Issue related to documentation. difficulty: medium Issue has medium complexity. kind: feature New feature request. scope: code Issue related to source code. scope: test Issue related to tests. and removed kind: improvement New improvement proposal. labels May 28, 2022
@kamilsk kamilsk changed the title support X-Features spread: middlewares: support X-Features header May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
difficulty: medium Issue has medium complexity. kind: feature New feature request. scope: code Issue related to source code. scope: docs Issue related to documentation. scope: test Issue related to tests.
Projects
🏗 Platform
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamilsk