Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantics of IPFS daemon identifier #610

Closed
machawk1 opened this issue May 28, 2019 · 0 comments · Fixed by #611
Closed

Fix semantics of IPFS daemon identifier #610

machawk1 opened this issue May 28, 2019 · 0 comments · Fixed by #611

Comments

@machawk1
Copy link
Member

machawk1 commented May 28, 2019

In #609 with the integration of the renamed ipfsapi python module, we were required to update using HOST and PORT for parameters to a multiaddress (i.e., beginning with /).

In #609 @ibnesayeed noted that HOST implies a hostname where sometimes an IP might be used instead. The distinction of host vs IP for this address is significant, as the multiaddress for each would be different (see Important changes from ipfs 0.4.x), e.g.,

  • ipfshttpclient.connect("/dns//tcp//http") (for hostnames such as localhost)
  • ipfshttpclient.connect("/ip4//tcp//http") (for IPv4 addresses)

If an IPFS daemon is remote (#349), this distinction is again important.

Let's modify this to be a single string of host/ip:port and interpret this string on usage, building the multiaddress in the manner that is applicable to the specified host/ip:port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant