New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings in AMO #2

Open

ofaurax opened this issue Jan 21, 2016 · 1 comment

Owner

ofaurax commented Jan 21, 2016

on* attribute being set using setAttribute

Avertissement: To prevent vulnerabilities, event handlers (like 'onclick' and 'onhover') should always be defined using addEventListener.
chrome/content/eotoolbar.js
var info = document.getElementById('eotoolbar-inforss');
info.setAttribute("oncommand",
    "gBrowser.selectedBrowser.loadURI('"+link.textContent+"');");

The text was updated successfully, but these errors were encountered:

Owner Author

ofaurax commented Nov 18, 2016

https://addons.mozilla.org/fr/developers/upload/2f45a11622c246329f5834588be71088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment