The popup feels slow

[praveshishere]

I am not sure if this is an issue, or is expected

but there is a delay, before the popup opens and, there is a delay when I navigate between sessions,
I disabled the preview still the same.

[alexanderfast]

Joining this issue since I experience the same thing. The one second delay before i can start typing is rather jarring compared to other plugins that do the same thing (dump session list to fzf).

It feels like something traversing a directory tree when it shouldnt, so I disabled the custom paths setting, in addition to the preview. Though I'm not entirely sure how I would go about profiling the bash scripts when run inside tmux.

set -g @sessionx-preview-enabled 'false'
set -g @sessionx-custom-paths-subdirectories 'false'

[praveshishere]

Joining this issue since I experience the same thing. The one second delay before i can start typing is rather jarring compared to other plugins that do the same thing (dump session list to fzf).

It feels like something traversing a directory tree when it shouldnt, so I disabled the custom paths setting, in addition to the preview. Though I'm not entirely sure how I would go about profiling the bash scripts when run inside tmux.

set -g @sessionx-preview-enabled 'false'
set -g @sessionx-custom-paths-subdirectories 'false'

I don't exactly understand the traversing part, but the config does not help make it any faster

[omerxx]

Hi folks, is there any update on this? Are you still feeling slowness?
Stating the obvious but - can you try with latest Tmux + FZF + vanilla sessoinx config and see whether it persists?

[LoricAndre]

I'm seeing it too, modifying the tmux_option_or_fallback calls to use the defaults earned me around 0.2 seconds. Would it be possible to expand those variables in the .tmux file and pass them to the script invocation in the keybind directly ? This would only run those calls once, instead of at every keybind.

[LoricAndre]

I tried my hand at a refactor to implement this in #152

[raymccarthy]

I have discovered three things, but I am not sure of the significance.

1. The plugin is lighting fast on my ubuntu dev macine
2. It takes nearly 3 seconds to open on my ARM MacBook running Macos Sequoia
3. It opens in less than half a second when I run the script directly on the command line of the Mac, without using the tmux key binding

So my conclusion is that the issue is in the tmux keybinding logic.

[ahmedYasserM]

Same thing here on Linux void 6.6.56_2, it takes about 1 second to open

[omerxx]

Hi everyone, i've pushed this today, inspired by #152 , can you please update and let me know whether the situations slightly improves?

[Marat-Gumerov]

I've updated the plugin a few minutes ago. It seems like it takes 630 ms for the popup to open. I think it is very good, but I still want better :)

[Marat-Gumerov]

The slowest thing I found in the logs is the tmux_option_or_fallback call, which takes around 8-9 ms. This function is called 42 times before the popup appears, so it takes around 350 ms total. For example, the call tmux_option_or_fallback @sessionx-bind-zo-new-window ctrl-f took 9 ms:

++ 1729574376.197823826  tmux_option_or_fallback @sessionx-bind-zo-new-window ctrl-f
++ 1729574376.198778377  local option_value
+++ 1729574376.199899770         tmux show-option -gqv @sessionx-bind-zo-new-window
++ 1729574376.203769773  option_value=
++ 1729574376.205028227  '[' -z '' ']'
++ 1729574376.205988512  option_value=ctrl-f
++ 1729574376.206872481  echo ctrl-f

[Marat-Gumerov]

I've replaced all tmux_option_or_fallback calls by values I prefer (or default ones). Now it takes only 213 ms for the popup to open. I think this plugin should have much less options or have a faster way to read them.

[omerxx]

@Marat-Gumerov interesting!! Thanks!
BTW - what did you use for the timings?

[Marat-Gumerov]

PS4='+ $(date "+%s.%N")\011 ' bash -x scripts/sessionx.sh

That's what ChatGPT suggested me to use

[omerxx]

@Marat-Gumerov care to give this version a try?
#154

I added caching to the parameters, should work quicker.
currently using a 5 min ttl, can be changed later

[Marat-Gumerov]

@omerxx, well, it seems a little bit worse than it was before. Sorry :(
Now it takes 645 ms with cache and 1090 ms without it.
Reading cache from file takes 146 ms.
tmux_option_or_fallback calls take 7-8 ms:

++ 1729679955.212351807  tmux_option_or_fallback @sessionx-tree-mode off
++ 1729679955.213401232  local option=@sessionx-tree-mode
++ 1729679955.214518419  local default=off
++ 1729679955.216097107  [[ -n x ]]
++ 1729679955.217340938  [[ -z '' ]]
++ 1729679955.218316582  echo off
++ 1729679955.219322282  return

So I still need 440 ms to read options in the best case.

Why don't you use the approach from #152? It seems like all this option reading stuff is handled during the sessionx.tmux file execution, so we don't have to execute it every single time we open the window. Isn't it better for performance?

Unfortunately, I can't test the #152 version right now so I don't know how fast it is :(

BTW, #152 breaks tmuxinator support right now.

[omerxx]

152 is not bad it just breaks a few things ATM, so I'm waiting for updates

[Marat-Gumerov]

I've found out how to test #152:

• Add the following lines to the end of the sessionx.tmux file:

export PS4='+ $(date "+%s.%N")\011 '
bash -x scripts/sessionx.sh "$(build_args) $(build_fzf_opts)"

• Run:

./sessionx.tmux

Now it takes around 215 ms on my machine.

[Marat-Gumerov]

@omerxx, I decided to implement my version, inspired by ideas from #152, thanks to @LoricAndre

Please take a look at #155

I hope this implementation does not break anything. BTW, I tested it with tmuxinator and it seems to be working as expected.

[Marat-Gumerov]

I feel like someone is busy rewriting this plugin from scratch using Nushell :-)