Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Flexibility: Optional Window Title Configuration #138

Open
samyakbardiya opened this issue Aug 21, 2024 · 3 comments
Open

Enhance Flexibility: Optional Window Title Configuration #138

samyakbardiya opened this issue Aug 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@samyakbardiya
Copy link

samyakbardiya commented Aug 21, 2024

Hello Omerxx, I am really liking your plug-in, kudos for the work.

Although I have one query, is there any specific reason that we are naming the window as well? The thing is that I use the Catppuccin theme, and it sets the window names for me. But as the window name is already set by this package, it then does not rename it. Also, this is just me, but I don't like full-path as my window name.

Code context

I would be happy to create a PR adding this as an optional configuration option, if there is no specific reason behind.

Thanks :)

@samyakbardiya samyakbardiya changed the title Query: Why setting window name? Enhance Flexibility: Optional Window Title Configuration Aug 21, 2024
@omerxx
Copy link
Owner

omerxx commented Sep 23, 2024

@samyakbardiya thanks! the reason is making windows easier to query in the console, where if you leave it to autonaming you may endup with lots of duplications or similar names that don't mean much.
If you want to add a functionality behind a switch I'm happy to accept it!

@omerxx omerxx added the enhancement New feature or request label Sep 23, 2024
@samyakbardiya
Copy link
Author

Thanks for the info @omerxx . I'll raise the PR in a few days.

@samyakbardiya
Copy link
Author

Sorry for the delay, was a bit busy lately. Now, I'm going to pick it.

I got a little confused while trying to implement it, on how the value of @sessionx-zoxide-mode, i.e., $Z_MODE, is being passed from sessionx.tmux (here) to scripts/sessionx.sh (here).

Could you please guide me a little?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants