Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete session doesn't work well with window-mode on #82

Open
kdowolski opened this issue Apr 16, 2024 · 1 comment
Open

Delete session doesn't work well with window-mode on #82

kdowolski opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kdowolski
Copy link

kdowolski commented Apr 16, 2024

  1. It doesn't delete session (as we feed kill-session with whole name, not just session)
  2. After operation it ignores window-mode setting and renders the view with just session names.

Maybe it could delete window rather than session? WDYT?

I am happy to open PR for that if you would like to!

@omerxx
Copy link
Owner

omerxx commented Apr 21, 2024

Hey @kdowolski
I'm actually seeing the session getting removed in window mode, do you experience something different?
In terms of killing just the window rather than the entire session, yes, I think that's preferable.

If you'd like to tweak things so that

  1. the window gets killed rather than the entire session while running window mode
  2. (if you want) keep window mode running after killing the window

I'll be happy to have it!

@omerxx omerxx added the enhancement New feature or request label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants